----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60637/#review180216 -----------------------------------------------------------
Ship it! Ship It! - Robert Levas On July 6, 2017, 7:08 a.m., Attila Magyar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60637/ > ----------------------------------------------------------- > > (Updated July 6, 2017, 7:08 a.m.) > > > Review request for Ambari, Balázs Bence Sári, Laszlo Puskas, Robert Levas, > and Sebastian Toader. > > > Bugs: AMBARI-21392 > https://issues.apache.org/jira/browse/AMBARI-21392 > > > Repository: ambari > > > Description > ------- > > Upon removing a service from the cluster, the relevant Kerberos identities > should be removed as well. This includes any principals and keytab files. > Care must be taken not to remove any principals or keytab files that are > still in use in the cluster. > > entry point is: KerberosIdentityCleaner>>serviceRemoved > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/DeleteIdentityHandler.java > aa098b6 > > ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java > cc0c048 > > ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java > b30f8f6 > > ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/KerberosIdentityCleaner.java > 0a8462f > > ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/RemovableIdentities.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/UsedIdentities.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/events/ServiceComponentUninstalledEvent.java > 5b55339 > > ambari-server/src/main/java/org/apache/ambari/server/events/ServiceRemovedEvent.java > aca00a8 > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ClusterDAO.java > a23b914 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterConfigEntity.java > 34f3034 > ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java > b4f7120 > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java > 5084703 > > ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java > 06b6217 > > ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/AbstractKerberosDescriptorContainer.java > 0a89c1d > > ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosComponentDescriptor.java > 41d1f65 > > ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosIdentityDescriptor.java > 2023793 > > ambari-server/src/test/java/org/apache/ambari/server/controller/utilities/KerberosIdentityCleanerTest.java > d22c92e > > ambari-server/src/test/java/org/apache/ambari/server/orm/dao/ServiceConfigDAOTest.java > 406349a > > > Diff: https://reviews.apache.org/r/60637/diff/4/ > > > Testing > ------- > > added new unittests. > end2end tested manually: > - created a cluster with spark1 and spark2 > - enabled kerberos > - removed spark1 > - checked that spark identity was NOT removed (because it was still used by > spark2) > - removed spark2 > - checked that the spark identity was removed > > existing tests: > > Tests run: 4800, Failures: 0, Errors: 0, Skipped: 35 > > ---------------------------------------------------------------------- > Ran 245 tests in 7.085s > > OK > ---------------------------------------------------------------------- > Total run:1145 > Total errors:0 > Total failures:0 > > > Thanks, > > Attila Magyar > >
