-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60813/#review180412
-----------------------------------------------------------


Fix it, then Ship it!




Ship It!


ambari-infra/ambari-infra-solr-client/src/main/resources/solrIndexHelper.sh
Lines 75 (patched)
<https://reviews.apache.org/r/60813/#comment255595>

    use shift 2



ambari-infra/ambari-infra-solr-client/src/main/resources/solrIndexHelper.sh
Lines 84 (patched)
<https://reviews.apache.org/r/60813/#comment255596>

    use shift 2



ambari-infra/ambari-infra-solr-client/src/main/resources/solrIndexHelper.sh
Lines 93 (patched)
<https://reviews.apache.org/r/60813/#comment255597>

    use if [ -z $... ]



ambari-infra/ambari-infra-solr-client/src/main/resources/solrIndexHelper.sh
Lines 98 (patched)
<https://reviews.apache.org/r/60813/#comment255598>

    use if [ -z $... ]



ambari-infra/ambari-infra-solr-client/src/main/resources/solrIndexHelper.sh
Lines 102 (patched)
<https://reviews.apache.org/r/60813/#comment255599>

    use if [ -z $... ]



ambari-infra/ambari-infra-solr-client/src/main/resources/solrIndexHelper.sh
Lines 110 (patched)
<https://reviews.apache.org/r/60813/#comment255593>

    This supposed to be $INDEX_DIR



ambari-infra/ambari-infra-solr-client/src/main/resources/solrIndexHelper.sh
Lines 140 (patched)
<https://reviews.apache.org/r/60813/#comment255594>

    Fix the indentations of the cases


- Miklos Gergely


On July 12, 2017, 7:03 p.m., Oliver Szabo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60813/
> -----------------------------------------------------------
> 
> (Updated July 12, 2017, 7:03 p.m.)
> 
> 
> Review request for Ambari, Miklos Gergely, Robert Nettleton, Sumit Mohanty, 
> and Sebastian Toader.
> 
> 
> Bugs: AMBARI-21459
>     https://issues.apache.org/jira/browse/AMBARI-21459
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Add script to migrate lucene index from version 5.x to lucene 6.x.
> 
> The bash cli tool implemeted without getopts as it has some issues on 
> different evironments.
> 
> Backup files not implemented as solr 6 has already a snapshot tool.
> 
> For more specific runs (e.g. using hdfs directory factory or exorcise corrupt 
> indices from files) check index and upgrade index tool can be run directly as 
> well.
> 
> Note: migration takes about 1 minute per 1 GB
> 
> 
> Diffs
> -----
> 
>   ambari-infra/ambari-infra-solr-client/build.xml a54e336 
>   ambari-infra/ambari-infra-solr-client/pom.xml d103003 
>   ambari-infra/ambari-infra-solr-client/src/main/resources/solrIndexHelper.sh 
> PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/60813/diff/1/
> 
> 
> Testing
> -------
> 
> done. run script manually with different use cases
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Reply via email to