----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60862/#review180539 -----------------------------------------------------------
Ugh - it stinks that we have to add all of these in to fix the issue. Is there no other way? - Can we change the UI to allow removal of services whose heartbeat is lost? That would prevent the need to add this stack back in. - Can we catch/throw a different exception in the agent when the file doesn't exist? - Jonathan Hurley On July 14, 2017, 8:23 a.m., Attila Doroszlai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60862/ > ----------------------------------------------------------- > > (Updated July 14, 2017, 8:23 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Di Li, Jonathan Hurley, Sumit > Mohanty, and Sid Wagle. > > > Bugs: AMBARI-21474 > https://issues.apache.org/jira/browse/AMBARI-21474 > > > Repository: ambari > > > Description > ------- > > * Added scripts to stack definition from BI 4.2.5's `common-services/HBASE` > * Applied 2 changes (AMBARI-21420 and AMBARI-21462) which fixed issues in > Ambari 2.5.2's `common-services/HBASE` > > > Diffs > ----- > > > ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HBASE/package/files/draining_servers.rb > PRE-CREATION > > ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HBASE/package/files/hbase-smoke-cleanup.sh > PRE-CREATION > > ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HBASE/package/files/hbaseSmokeVerify.sh > PRE-CREATION > > ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HBASE/package/scripts/__init__.py > PRE-CREATION > > ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HBASE/package/scripts/functions.py > PRE-CREATION > > ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HBASE/package/scripts/hbase.py > PRE-CREATION > > ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HBASE/package/scripts/hbase_client.py > PRE-CREATION > > ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HBASE/package/scripts/hbase_decommission.py > PRE-CREATION > > ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HBASE/package/scripts/hbase_master.py > PRE-CREATION > > ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HBASE/package/scripts/hbase_regionserver.py > PRE-CREATION > > ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HBASE/package/scripts/hbase_restgatewayserver.py > PRE-CREATION > > ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HBASE/package/scripts/hbase_service.py > PRE-CREATION > > ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HBASE/package/scripts/hbase_upgrade.py > PRE-CREATION > > ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HBASE/package/scripts/params.py > PRE-CREATION > > ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HBASE/package/scripts/params_linux.py > PRE-CREATION > > ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HBASE/package/scripts/params_windows.py > PRE-CREATION > > ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HBASE/package/scripts/phoenix_queryserver.py > PRE-CREATION > > ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HBASE/package/scripts/phoenix_service.py > PRE-CREATION > > ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HBASE/package/scripts/service_check.py > PRE-CREATION > > ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HBASE/package/scripts/setup_ranger_hbase.py > PRE-CREATION > > ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HBASE/package/scripts/status_params.py > PRE-CREATION > > ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HBASE/package/scripts/upgrade.py > PRE-CREATION > > ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HBASE/package/templates/hadoop-metrics2-hbase.properties-GANGLIA-MASTER.j2 > PRE-CREATION > > ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HBASE/package/templates/hadoop-metrics2-hbase.properties-GANGLIA-RS.j2 > PRE-CREATION > > ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HBASE/package/templates/hbase-smoke.sh.j2 > PRE-CREATION > > ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HBASE/package/templates/hbase.conf.j2 > PRE-CREATION > > ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HBASE/package/templates/hbase_client_jaas.conf.j2 > PRE-CREATION > > ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HBASE/package/templates/hbase_grant_permissions.j2 > PRE-CREATION > > ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HBASE/package/templates/hbase_master_jaas.conf.j2 > PRE-CREATION > > ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HBASE/package/templates/hbase_queryserver_jaas.conf.j2 > PRE-CREATION > > ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HBASE/package/templates/hbase_regionserver_jaas.conf.j2 > PRE-CREATION > > ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HBASE/package/templates/hbase_rest_jaas.conf.j2 > PRE-CREATION > > ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/HBASE/package/templates/regionservers.j2 > PRE-CREATION > > > Diff: https://reviews.apache.org/r/60862/diff/1/ > > > Testing > ------- > > * Tested that HBASE_REST_SERVER can be stopped and deleted (host component > via UI, service component only via API) after Ambari upgrade > * Tested upgrade to HDP-2.6 after removing HBASE_REST_SERVER > > > Thanks, > > Attila Doroszlai > >
