> On Липень 17, 2017, 10:39 після полудня, Sumit Mohanty wrote:
> > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py
> > Lines 100 (patched)
> > <https://reviews.apache.org/r/60921/diff/1/?file=1777979#file1777979line100>
> >
> > With the java change, will this error path be hit?
Java part will just remove invalid values from list. In python side i've added
validation for hdfs_tmp_dir, i thought it will be good to infrom user that he
has potential problem. Also, if hdfs_tmp_dir not correct ("null" or empty),
history server start will fail.
- Vitalyi
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60921/#review180757
-----------------------------------------------------------
On Липень 17, 2017, 8:14 після полудня, Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60921/
> -----------------------------------------------------------
>
> (Updated Липень 17, 2017, 8:14 після полудня)
>
>
> Review request for Ambari, Andrew Onischuk, Sumit Mohanty, and Sid Wagle.
>
>
> Bugs: AMBARI-21504
> https://issues.apache.org/jira/browse/AMBARI-21504
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Steps:
>
> * Installed Ambari 2.2 with Slider and services it required
> * Upgraded Ambari to 2.5.2.0-134
> * Registered HDP 2.6.1.0 repo, installed packages
> * Restarted services that needed restart
> * Ran service checks
> * Started upgrade
>
> Result: _Restarting History Server_ step failed with
>
> {noformat:title=errors-91.txt}
> Traceback (most recent call last):
> File
> "/var/lib/ambari-agent/cache/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py",
> line 134, in <module>
> HistoryServer().execute()
> File
> "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
> line 329, in execute
> method(env)
> File
> "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
> line 841, in restart
> self.pre_upgrade_restart(env, upgrade_type=upgrade_type)
> File
> "/var/lib/ambari-agent/cache/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py",
> line 85, in pre_upgrade_restart
> copy_to_hdfs("mapreduce", params.user_group, params.hdfs_user,
> skip=params.sysprep_skip_copy_tarballs_hdfs)
> File
> "/usr/lib/python2.6/site-packages/resource_management/libraries/functions/copy_tarball.py",
> line 256, in copy_to_hdfs
> mode=0555
> File "/usr/lib/python2.6/site-packages/resource_management/core/base.py",
> line 155, in __init__
> self.env.run()
> File
> "/usr/lib/python2.6/site-packages/resource_management/core/environment.py",
> line 160, in run
> self.run_action(resource, action)
> File
> "/usr/lib/python2.6/site-packages/resource_management/core/environment.py",
> line 124, in run_action
> provider_action()
> File
> "/usr/lib/python2.6/site-packages/resource_management/libraries/providers/hdfs_resource.py",
> line 560, in action_create_on_execute
> self.action_delayed("create")
> File
> "/usr/lib/python2.6/site-packages/resource_management/libraries/providers/hdfs_resource.py",
> line 550, in action_delayed
> parsed_not_managed_paths = [HdfsResourceProvider.parse_path(path) for
> path in self.resource.immutable_paths]
> File
> "/usr/lib/python2.6/site-packages/resource_management/libraries/providers/hdfs_resource.py",
> line 519, in parse_path
> math_with_protocol_and_nn_url = re.match("[a-zA-Z]+://[^/]+(/.+)", path)
> File "/usr/lib64/python2.7/re.py", line 137, in match
> return _compile(pattern, flags).match(string)
> TypeError: expected string or buffer
> {noformat}
>
> {noformat:title=command-91.json}
> "hostLevelParams": {
> ...
> "not_managed_hdfs_path_list": "[null,\"/mr-history/done\",\"/app-logs\"]",
> ...
> }
> {noformat}
>
> Failure seems to be due to {{null}} value in the list.
>
>
> Diffs
> -----
>
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
> 9b19ade
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
> 82171f6
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
> daca2d0
>
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java
> ab8026c
>
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py
> 9a9f9ca
>
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service.py
> 6495209
>
> ambari-server/src/test/java/org/apache/ambari/server/state/ConfigHelperTest.java
> b1c10f5
>
>
> Diff: https://reviews.apache.org/r/60921/diff/1/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
