> On Июль 20, 2017, 6:55 п.п., Sid Wagle wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > > Lines 3367 (patched) > > <https://reviews.apache.org/r/60999/diff/1/?file=1780283#file1780283line3367> > > > > Can you please add comments why we need to track this separately?
For simpler maintenance. > On Июль 20, 2017, 6:55 п.п., Sid Wagle wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > > Lines 3661 (patched) > > <https://reviews.apache.org/r/60999/diff/1/?file=1780283#file1780283line3661> > > > > Can we call this something more meaningful than temp2 ? Fixed. - Dmytro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60999/#review181074 ----------------------------------------------------------- On Июль 21, 2017, 11 д.п., Dmytro Sen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60999/ > ----------------------------------------------------------- > > (Updated Июль 21, 2017, 11 д.п.) > > > Review request for Ambari, Aravindan Vijayan, Sumit Mohanty, Sid Wagle, and > Vitalyi Brodetskyi. > > > Bugs: AMBARI-21345 > https://issues.apache.org/jira/browse/AMBARI-21345 > > > Repository: ambari > > > Description > ------- > > Additional patch to solve naming issues > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java > 0b140e4 > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > 44943c7 > > > Diff: https://reviews.apache.org/r/60999/diff/2/ > > > Testing > ------- > > Manual testing. > > > Thanks, > > Dmytro Sen > >
