-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61036/
-----------------------------------------------------------
Review request for Ambari, Jonathan Hurley and Nate Cole.
Bugs: AMBARI-21549
https://issues.apache.org/jira/browse/AMBARI-21549
Repository: ambari
Description
-------
When upgrading Ambari from 2.2.2 to 2.5 it was discovered that if a unique
constraint is modified between Ambari versions, then we do not update the
unique constraint.
For example:
*Ambari 2.2.2*
https://github.com/apache/ambari/blob/branch-2.2.2/ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql#L661
{code}
ALTER TABLE users ADD CONSTRAINT UNQ_users_0 UNIQUE (user_name, ldap_user);
{code}
*Ambari-2.4.0*
https://github.com/apache/ambari/blob/branch-2.4/ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql#L288
{code}
CONSTRAINT UNQ_users_0 UNIQUE (user_name, user_type))
{code}
Whenever after upgrading from Ambari 2.2.2 to Ambari 2.5.0, the unique
constraint is not updated.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessor.java
03136984ba
ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessorImpl.java
38d60e9a4a
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog230.java
6cda590d37
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java
cd7ae459f7
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog230Test.java
947ba2e30c
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java
2590d1c995
Diff: https://reviews.apache.org/r/61036/diff/1/
Testing
-------
mvn clean test
Thanks,
Dmitro Lisnichenko
