----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61043/#review181235 -----------------------------------------------------------
Ship it! It looks good to me. It is similar to the change set included as part of IOP supporting QuickLinks through Knox. Can we make sure all the tests run by HadoopQA pass, even if they are not related to this change? - Juanjo Marron On July 21, 2017, 6:57 p.m., Chandana Mirashi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61043/ > ----------------------------------------------------------- > > (Updated July 21, 2017, 6:57 p.m.) > > > Review request for Ambari, Balázs Bence Sári, Juanjo Marron, and Sid Wagle. > > > Bugs: AMBARI-21325 > https://issues.apache.org/jira/browse/AMBARI-21325 > > > Repository: ambari > > > Description > ------- > > Add quicklink support through Knox. > Changes: > 1. Add new json properties knox_url, knox_path, supports_knox > a. knox_url: template to be used for urls that are proxied through Knox > b. knox_path: Knox gateway path that will be added to the proxy url. > c. supports_knox: whether link will be redirected through Knox > 2. Add above json properties to quicklinks.json > 3. Add HDFSUI & DATANODE,YARNUI & NODEUI, JOBHISTORYUI, HBASEUI, OOZIEUI, > SPARKUI services to Knox topology template. > 4. Automate protocol and port added to Knox topology file. Based on whether > SSL is enabled for the services listed above, the port and protocol in > params_linux.py will be updated. > 5. Update quick_view_link_view.js so that when Knox is installed and > support_knox is true, quicklink url follows knox url template specified in > the quicklinks.json for the service/component. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/state/quicklinks/Link.java > 1d2e712 > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py > 4558069 > > ambari-server/src/main/resources/stacks/HDP/2.3/services/HBASE/quicklinks/quicklinks.json > 5568122 > > ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/quicklinks/quicklinks.json > a4216e3 > > ambari-server/src/main/resources/stacks/HDP/2.3/services/OOZIE/quicklinks/quicklinks.json > 81e7cbe > > ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/quicklinks-mapred/quicklinks.json > 36f71b5 > > ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/quicklinks/quicklinks.json > 0aca8e3 > > ambari-server/src/main/resources/stacks/HDP/2.6/services/KNOX/configuration/topology.xml > df4c1b4 > ambari-server/src/test/python/stacks/2.2/configs/knox_upgrade.json 1805c3b > ambari-web/app/views/common/quick_view_link_view.js e39f230 > > > Diff: https://reviews.apache.org/r/61043/diff/1/ > > > Testing > ------- > > 1. ambari-server: mvn test > 2. mvn -DskipSurefireTests -Dpython.test.mask=test_knox_gateway.py test > 3. ambari-web: mvn test > 21213 passing (54s) > 128 pending > > > Thanks, > > Chandana Mirashi > >
