-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61079/
-----------------------------------------------------------
(Updated July 25, 2017, 12:06 p.m.)
Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Sumit Mohanty,
and Sid Wagle.
Changes
-------
keep most of `source`, only update `path`
Bugs: AMBARI-21559
https://issues.apache.org/jira/browse/AMBARI-21559
Repository: ambari
Description
-------
Update script paths during Ambari upgrade.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
2d13cbaa764dfdf8338f0fcd2aaf48083515f825
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
e8c986b9a51ad557f1f600ff77ad89fc38f5707c
ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertDefinitionFactory.java
acbb881264ae2c89a371063f57214e42c7ca7001
ambari-server/src/main/java/org/apache/ambari/server/state/alert/ScriptSource.java
d1b70701ae26c3117f7b9fb8ece2676c0f3d45cb
ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractFinalUpgradeCatalog.java
PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/upgrade/FinalUpgradeCatalog.java
1ac011862bff70742e99d627068225617d73d66d
ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java
af2a7d1cce7cfbc590415fff431be2d6d7308078
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpdateAlertScriptPaths.java
PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java
bc1c19af6d637af5d2284f65fe05fa7f53bc4f90
Diff: https://reviews.apache.org/r/61079/diff/2/
Changes: https://reviews.apache.org/r/61079/diff/1-2/
Testing
-------
Tested manually on local cluster. No alerts are skipped due to non-existent
scripts.
```
24 Jul 2017 11:17:54,753 INFO [main] AmbariMetaInfo:1186 - Updating script
path for the alert named namenode_ha_health from
'HDFS/2.7.2.4.2/package/alerts/alert_ha_namenode_health.py' to
'BigInsights/4.2/services/HDFS/package/alerts/alert_ha_namenode_health.py'
24 Jul 2017 11:17:54,753 INFO [main] AmbariMetaInfo:1186 - Updating script
path for the alert named upgrade_finalized_state from
'HDFS/2.7.2.4.2/package/alerts/alert_upgrade_finalized.py' to
'BigInsights/4.2/services/HDFS/package/alerts/alert_upgrade_finalized.py'
24 Jul 2017 11:17:54,753 INFO [main] AmbariMetaInfo:1186 - Updating script
path for the alert named datanode_unmounted_data_dir from
'HDFS/2.7.2.4.2/package/alerts/alert_datanode_unmounted_data_dir.py' to
'BigInsights/4.2/services/HDFS/package/alerts/alert_datanode_unmounted_data_dir.py'
24 Jul 2017 11:17:54,754 INFO [main] AmbariMetaInfo:1186 - Updating script
path for the alert named namenode_last_checkpoint from
'HDFS/2.7.2.4.2/package/alerts/alert_checkpoint_time.py' to
'BigInsights/4.2/services/HDFS/package/alerts/alert_checkpoint_time.py'
24 Jul 2017 11:17:54,754 INFO [main] AmbariMetaInfo:1186 - Updating script
path for the alert named flume_agent_status from
'FLUME/1.6.0.4.2/package/alerts/alert_flume_agent_status.py' to
'BigInsights/4.2/services/FLUME/package/alerts/alert_flume_agent_status.py'
24 Jul 2017 11:17:54,754 INFO [main] AmbariMetaInfo:1186 - Updating script
path for the alert named ams_metrics_monitor_process from
'AMBARI_METRICS/0.1.0.4.1/package/alerts/alert_ambari_metrics_monitor.py' to
'BigInsights/4.2/services/AMBARI_METRICS/package/alerts/alert_ambari_metrics_monitor.py'
```
Existing unit tests:
```
$ mvn -am -pl ambari-server clean test
...
Tests run: 5003, Failures: 0, Errors: 0, Skipped: 39
...
Total run:1162
Total errors:0
Total failures:0
OK
...
[INFO] BUILD SUCCESS
```
Thanks,
Attila Doroszlai
