> On July 25, 2017, 10:31 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/params_linux.py > > Lines 43 (patched) > > <https://reviews.apache.org/r/61102/diff/1/?file=1782054#file1782054line43> > > > > We should instead look if any hosts have Tez Client.
What's the condition for that? > On July 25, 2017, 10:31 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/config-upgrade.xml > > Lines 75 (patched) > > <https://reviews.apache.org/r/61102/diff/1/?file=1782056#file1782056line75> > > > > HDP 2.6 defaults to exectype=tez, so why was this needed? Because BI doesn't have Tez, nor does HDP after the upgrade. - Attila ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61102/#review181372 ----------------------------------------------------------- On July 25, 2017, 4:11 p.m., Attila Doroszlai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61102/ > ----------------------------------------------------------- > > (Updated July 25, 2017, 4:11 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Jayush > Luniya, Oliver Szabo, Sumit Mohanty, Sebastian Toader, and Sid Wagle. > > > Bugs: AMBARI-21568 > https://issues.apache.org/jira/browse/AMBARI-21568 > > > Repository: ambari > > > Description > ------- > > * Execute Tez-specific part in Pig service check only if Tez is present in > the cluster. > * HDP 2.6 comes with `exectype=tez`. Change it back to `exectype=mapreduce` > for upgrade from BI. > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/params_linux.py > 5af127414288b29114212684d099301b6ba35357 > > ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/service_check.py > ba4082e61a073cfb92ca992e01a6464d15eb2bd1 > > ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/config-upgrade.xml > 87a2aef4a612189510a9761760d8973959680511 > > ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/nonrolling-upgrade-to-hdp-2.6.xml > a7ddd5c1a6cadf14acc4714c88a775fceb8e2a8d > > ambari-server/src/main/resources/stacks/BigInsights/4.2/upgrades/config-upgrade.xml > 6d00a90b679cef19c956ae9cb154c77574d88aec > > ambari-server/src/main/resources/stacks/BigInsights/4.2/upgrades/nonrolling-upgrade-to-hdp-2.6.xml > cedc90fb47ccd6824bb36a9bd62f89429a48582a > > > Diff: https://reviews.apache.org/r/61102/diff/1/ > > > Testing > ------- > > * Pig service check on cluster upgraded from BI 4.2: > > ``` > ... > 2017-07-24 19:16:05,079 [main] INFO org.apache.pig.Main - Pig script > completed in 34 seconds and 863 milliseconds (34863 ms) > 2017-07-24 19:16:06,008 - ExecuteHadoop['fs -test -e > /user/ambari-qa/pigsmoke.out'] {'bin_dir': > '/usr/hdp/current/hadoop-client/bin', 'user': 'ambari-qa', 'conf_dir': > '/usr/hdp/current/hadoop-client/conf'} > 2017-07-24 19:16:06,012 - Execute['hadoop --config > /usr/hdp/current/hadoop-client/conf fs -test -e > /user/ambari-qa/pigsmoke.out'] {'logoutput': None, 'try_sleep': 0, > 'environment': {}, 'tries': 1, 'user': 'ambari-qa', 'path': > ['/usr/hdp/current/hadoop-client/bin']} > > Command completed successfully! > ``` > > * Pig service check on cluster upgraded from BI 4.2 with Tez installed after > the upgrade: > > ``` > ... > 2017-07-25 07:13:45,352 [pool-1-thread-1] INFO > org.apache.tez.client.TezClient - Shutting down Tez Session, > sessionName=PigLatin:pigSmoke.sh, applicationId=application_1500966646772_0002 > 2017-07-25 07:13:46,049 - ExecuteHadoop['fs -test -e > /user/ambari-qa/pigsmoke.out'] {'bin_dir': > '/usr/hdp/current/hadoop-client/bin', 'user': 'ambari-qa', 'conf_dir': > '/usr/hdp/current/hadoop-client/conf'} > 2017-07-25 07:13:46,052 - Execute['hadoop --config > /usr/hdp/current/hadoop-client/conf fs -test -e > /user/ambari-qa/pigsmoke.out'] {'logoutput': None, 'try_sleep': 0, > 'environment': {}, 'tries': 1, 'user': 'ambari-qa', 'path': > ['/usr/hdp/current/hadoop-client/bin']} > > Command completed successfully! > ``` > > * Pig service check on cluster upgraded from BI 4.2.5: > > ``` > 2017-07-25 08:16:17,511 [main] INFO org.apache.pig.Main - Pig script > completed in 34 seconds and 276 milliseconds (34276 ms) > 2017-07-25 08:16:18,209 - ExecuteHadoop['fs -test -e > /user/ambari-qa/pigsmoke.out'] {'bin_dir': > '/usr/hdp/current/hadoop-client/bin', 'user': 'ambari-qa', 'conf_dir': > '/usr/hdp/current/hadoop-client/conf'} > 2017-07-25 08:16:18,212 - Execute['hadoop --config > /usr/hdp/current/hadoop-client/conf fs -test -e > /user/ambari-qa/pigsmoke.out'] {'logoutput': None, 'try_sleep': 0, > 'environment': {}, 'tries': 1, 'user': 'ambari-qa', 'path': > ['/usr/hdp/current/hadoop-client/bin']} > > Command completed successfully! > ``` > > * Pig service check on fresh HDP 2.6 install. > > > Thanks, > > Attila Doroszlai > >
