> On Липень 25, 2017, 11:41 після полудня, Sumit Mohanty wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.6/role_command_order.json
> > Lines 6 (patched)
> > <https://reviews.apache.org/r/61107/diff/3/?file=1782408#file1782408line6>
> >
> >     This, we can drop as we are not planning to add HBASE_REST_SERVER as a 
> > component.

Done


> On Липень 25, 2017, 11:41 після полудня, Sumit Mohanty wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.6/services/HBASE/configuration/hbase-env.xml
> > Lines 122 (patched)
> > <https://reviews.apache.org/r/61107/diff/3/?file=1782409#file1782409line122>
> >
> >     This should not be true after Ambari upgrade. EU upgrade pack should 
> > edit the config property and append the path.

Done


> On Липень 25, 2017, 11:41 після полудня, Sumit Mohanty wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.6/services/YARN/configuration-mapred/mapred-site.xml
> > Lines 28 (patched)
> > <https://reviews.apache.org/r/61107/diff/3/?file=1782412#file1782412line28>
> >
> >     Lets not make it true on-ambari-upgrade but we need a change in the EU 
> > upgrade pack to append the path to the config property.

Done


> On Липень 25, 2017, 11:41 після полудня, Sumit Mohanty wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.6/services/YARN/configuration/yarn-site.xml
> > Line 22 (original), 22 (patched)
> > <https://reviews.apache.org/r/61107/diff/3/?file=1782413#file1782413line22>
> >
> >     Do we need this change during the EU?

I think yes. If user will decide to enable custom extensions, this path needs 
to be added to classpath. And it's not only for YARN but for HIVE and HBASE 
too. Will create separate jira for this.


- Vitalyi


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61107/#review181405
-----------------------------------------------------------


On Липень 25, 2017, 11:29 після полудня, Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61107/
> -----------------------------------------------------------
> 
> (Updated Липень 25, 2017, 11:29 після полудня)
> 
> 
> Review request for Ambari, Andrew Onischuk, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-21570
>     https://issues.apache.org/jira/browse/AMBARI-21570
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Support custom extension to load third party libraries for integration with 
> other vendors
> 
> 
> Diffs
> -----
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
>  c74e029 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/custom_extensions.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/hook.py
>  f7705c4 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py
>  2e7f5cd 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  31cf0c8 
>   ambari-server/src/main/resources/stacks/HDP/2.6/role_command_order.json 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/HBASE/configuration/hbase-env.xml
>  9afaecb 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/HDFS/configuration/hadoop-env.xml
>  04b9304 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/HIVE/configuration/hive-env.xml
>  929c10d 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/YARN/configuration-mapred/mapred-site.xml
>  f03125b 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/YARN/configuration/yarn-site.xml
>  5f8de49 
> 
> 
> Diff: https://reviews.apache.org/r/61107/diff/3/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Reply via email to