> On July 26, 2017, 6:43 p.m., Robert Nettleton wrote: > > ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/LogSearchConfig.java > > Lines 67 (patched) > > <https://reviews.apache.org/r/60943/diff/3/?file=1780214#file1780214line67> > > > > Would it make more sense to have a single "inputConfigExists" method, > > and then have implementations that are specific to the Logfeeder or the > > LogSearch Server?
If the function is called from the Log Search Server then it also must be specified which cluster we are asking for, while when it is called from Log Feeder it is obvious. Their default ZK implementation uses different caches too (Log Search Server caches the data of all the clusters, while Log Feeder caches only it's own cluster's shipper configs) Later I'll split the LogSearchConfigAPI into two interfaces (and it's default implementation into two classes) having a common ancestor. Then both interfaces will have an inputConfigExists method with different signature. - Miklos ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60943/#review181476 ----------------------------------------------------------- On July 20, 2017, 9:54 a.m., Miklos Gergely wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60943/ > ----------------------------------------------------------- > > (Updated July 20, 2017, 9:54 a.m.) > > > Review request for Ambari, Oliver Szabo and Robert Nettleton. > > > Bugs: AMBARI-21507 > https://issues.apache.org/jira/browse/AMBARI-21507 > > > Repository: ambari > > > Description > ------- > > The Solr output properties should be persisted into the Config API by the Log > Search Server as the output is initialized, and fetched by he Log Feeders > from there > > > Diffs > ----- > > > ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/LogSearchConfig.java > 6c5cefd > > ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/OutputConfigMonitor.java > PRE-CREATION > > ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/outputconfig/OutputProperties.java > PRE-CREATION > > ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/outputconfig/OutputSolrProperties.java > PRE-CREATION > > ambari-logsearch/ambari-logsearch-config-api/src/test/java/org/apache/ambari/logsearch/config/api/LogSearchConfigClass1.java > 28844d5 > > ambari-logsearch/ambari-logsearch-config-api/src/test/java/org/apache/ambari/logsearch/config/api/LogSearchConfigClass2.java > 5934fa6 > > ambari-logsearch/ambari-logsearch-config-zookeeper/src/main/java/org/apache/ambari/logsearch/config/zookeeper/LogSearchConfigZK.java > fdd8ed6 > > ambari-logsearch/ambari-logsearch-config-zookeeper/src/main/java/org/apache/ambari/logsearch/config/zookeeper/model/outputconfig/impl/OutputSolrPropertiesImpl.java > PRE-CREATION > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/LogFeeder.java > 59c2a22 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/common/ConfigHandler.java > 5bf074c > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/common/LogEntryParseTester.java > 5356159 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputConfigUploader.java > 09fc3f5 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputSimulate.java > f1002ae > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/Output.java > 65b9e19 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputManager.java > 4d6c43b > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputSolr.java > 162a7f8 > > ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/output/OutputSolrTest.java > 8985110 > > ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/SolrAuditLogPropsConfig.java > c569a27 > > ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/SolrEventHistoryPropsConfig.java > 975e6a7 > > ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/SolrPropsConfig.java > ceddf7e > > ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/SolrServiceLogPropsConfig.java > e5039d5 > > ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/configurer/LogSearchConfigConfigurer.java > c34dce6 > > ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/configurer/SolrCollectionConfigurer.java > f2d022e > > ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/dao/AuditSolrDao.java > 3eea08f > > ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/dao/ServiceLogsSolrDao.java > 308ef1f > > ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/dao/SolrDaoBase.java > b30b6ef > > ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/handler/CreateCollectionHandler.java > 752a1e1 > > ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/manager/ShipperConfigManager.java > 2c143c0 > > ambari-logsearch/docker/test-config/logfeeder/shipper-conf/output.config.json > 55fd36c > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog300.java > b4502d6 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/output.config.json.j2 > 214e5ba > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/service_advisor.py > fc49824 > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog300Test.java > d7bdf75 > > > Diff: https://reviews.apache.org/r/60943/diff/3/ > > > Testing > ------- > > Tested on docker and vagrant. Also tested with external Log Search server. > > > Thanks, > > Miklos Gergely > >
