----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61162/#review181572 -----------------------------------------------------------
Ship it! Ship It! - Robert Levas On July 26, 2017, 5:22 p.m., Balázs Bence Sári wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61162/ > ----------------------------------------------------------- > > (Updated July 26, 2017, 5:22 p.m.) > > > Review request for Ambari, Andrii Tkach, Jaimin Jetly, Miklos Gergely, Oliver > Szabo, Robert Levas, Sebastian Toader, and Yusaku Sako. > > > Bugs: AMBARI-21579 > https://issues.apache.org/jira/browse/AMBARI-21579 > > > Repository: ambari > > > Description > ------- > > Ooize quick links didn't work whith SSL enables die to two reasons: > > 1. Typos in the quicklink definitions (quicklinks.json) - fixed in this patch > > 2. An Oozie bug that prohibits changing the oozie-site/oozie.base.url > property to the https address. The port for the quick link address was taken > from this property. > > Issue #2 has been worked around in the patch by the using the > oozie-site/oozie.https.port to determine the port for the https quick link. > Code has been slightly changed to support custom regex to parse the https > port for the quicklink. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/state/quicklinks/Port.java > 7bd4b81 > > ambari-server/src/main/resources/common-services/OOZIE/4.2.0.2.3/quicklinks/quicklinks.json > 6353220 > > ambari-server/src/main/resources/common-services/OOZIE/4.2.0.3.0/quicklinks/quicklinks.json > 81e7cbe > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/quicklinks/quicklinks.json > f83bb5c > > ambari-server/src/main/resources/stacks/HDP/2.3/services/OOZIE/quicklinks/quicklinks.json > 81e7cbe > > ambari-server/src/test/java/org/apache/ambari/server/stack/QuickLinksConfigurationModuleTest.java > e37eaf0 > ambari-server/src/test/resources/parent_quicklinks.json 0aca8e3 > ambari-web/app/views/common/quick_view_link_view.js e39f230 > ambari-web/test/views/common/quick_link_view_test.js 48cdb28 > > > Diff: https://reviews.apache.org/r/61162/diff/1/ > > > Testing > ------- > > - manually tested the fix > - wrote to javascript unit tests > - extended a java unit tests > - unit tests pass in ambari-web (21223 passing / 128 pending) > - java unit tests pass in ambari-server > - 13 python unit test fail in ambari-server to an unrelated commit (the tests > fail in CI builds too) > > > Thanks, > > Balázs Bence Sári > >
