> On July 31, 2017, 7:19 a.m., Alejandro Fernandez wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java > > Lines 509 (patched) > > <https://reviews.apache.org/r/61239/diff/1/?file=1785542#file1785542line509> > > > > Why is this assuming Power PC will exist?
Hello Alejandro, It does not assume it must be PPC. It must check the OS type though and most importantly, if the current OS type is PPC. So I could change the method name, but the logic remains the same. If you know any existing logic that tell such info, please let me know, I can switch to using that instead. - Di ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61239/#review181787 ----------------------------------------------------------- On July 29, 2017, 2:12 a.m., Di Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61239/ > ----------------------------------------------------------- > > (Updated July 29, 2017, 2:12 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Sid Wagle, > and Tim Thorpe. > > > Bugs: AMBARI-21611 > https://issues.apache.org/jira/browse/AMBARI-21611 > > > Repository: ambari > > > Description > ------- > > Error message: Repositories for os type redhat-ppc7 are not defined. > This is because: > AmbariAgent reports os type (to be stored in the Hosts table) as redhat-ppc7. > "-ppc" is a hardcoded post fix attached to the os type in os_check.py > """ > os_check.py (AMBARI-21054) > if _is_powerpc(): > operatingSystem += '-ppc' > """ > When Ambari server backend generates the > {os, repo} > map, it uses os information from repo_versoin as the key . But later on uses > os info from the Hosts table to query the map, thus the mismatch (redhat-ppc7 > vs redhat7). > The repo_version table repository column however only uses redhat6/7 and does > not distinguish ppc vs x86 ( nor it should ) > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java > 633fe8c > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java > 7018245 > > > Diff: https://reviews.apache.org/r/61239/diff/1/ > > > Testing > ------- > > one IOP ppc one IOP x86, upgrade Ambari, patch with server jar, run install > packages after registering HDP 2.6.2 stack. verify the error did not appear > any more for ppc, both ppc and x86 cluster were able to finish the install > package step successfully > > > Thanks, > > Di Li > >
