> On July 31, 2017, 5:24 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java > > Lines 1111 (patched) > > <https://reviews.apache.org/r/61266/diff/1/?file=1786144#file1786144line1111> > > > > Never hit here
Ah- hahahahahahaha! Nice catch - thank you! - Nate ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61266/#review181847 ----------------------------------------------------------- On July 31, 2017, 5:35 p.m., Nate Cole wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61266/ > ----------------------------------------------------------- > > (Updated July 31, 2017, 5:35 p.m.) > > > Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, and Jonathan > Hurley. > > > Bugs: AMBARI-21617 > https://issues.apache.org/jira/browse/AMBARI-21617 > > > Repository: ambari > > > Description > ------- > > ru_set_all.py is broken with command changes. > > In addition, full RU was breaking because of cluster-env not being brought > over. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Stage.java > a01313e7fc > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java > c26f062e07 > > ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java > 827037056d > > ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContext.java > 6f469e5db3 > > ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java > a5881d2bf3 > ambari-server/src/main/resources/custom_actions/scripts/ru_set_all.py > a7732d97f1 > > ambari-server/src/test/java/org/apache/ambari/server/actionmanager/ExecutionCommandWrapperTest.java > e20b7b31d5 > > ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java > 229b864aaa > > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java > 011214c178 > > ambari-server/src/test/java/org/apache/ambari/server/controller/BackgroundCustomCommandExecutionTest.java > 4c237a769b > > ambari-server/src/test/java/org/apache/ambari/server/controller/RefreshYarnCapacitySchedulerReleaseConfigTest.java > 122e4efc6d > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java > c5fc039294 > > ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java > f0b884be07 > > ambari-server/src/test/java/org/apache/ambari/server/topology/AmbariContextTest.java > e798a4c29e > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalogTest.java > fbf5e05e3a > ambari-server/src/test/python/custom_actions/test_ru_set_all.py 8e03b7f26d > > ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_execute_task_test.xml > PRE-CREATION > > ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test_HDP-250.xml > PRE-CREATION > > > Diff: https://reviews.apache.org/r/61266/diff/2/ > > > Testing > ------- > > Manual. Automated pending. > > > Thanks, > > Nate Cole > >
