> On Aug. 2, 2017, 5:10 p.m., Sid Wagle wrote: > > ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/package/scripts/params_linux.py > > Line 248 (original), 248 (patched) > > <https://reviews.apache.org/r/61273/diff/2/?file=1788282#file1788282line248> > > > > The description only mentions the HDFS issue but changes are done for > > YARN. Is the RM behavior the same as NN? > > Dmytro Sen wrote: > Yarn works fine in both cases (when the host is in both files, and when > the host is in only exclude file with include file enabled). I decided to > change yarn code for symmetry and it also simplifies the params files. Does > that make sense?
Yes I think levaing it in both files is confusing and we should not do that. - Sid ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61273/#review182003 ----------------------------------------------------------- On Aug. 2, 2017, 3:08 p.m., Dmytro Sen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61273/ > ----------------------------------------------------------- > > (Updated Aug. 2, 2017, 3:08 p.m.) > > > Review request for Ambari, Sumit Mohanty, Sid Wagle, and Vitalyi Brodetskyi. > > > Bugs: AMBARI-21621 > https://issues.apache.org/jira/browse/AMBARI-21621 > > > Repository: ambari > > > Description > ------- > > If DN is deleted the hostname is removed from exclude file and refreshnodes > command is called. If those actions are not followed by NN restart, the > deleted DN will be shown as DEAD on NN UI. > > The slave should be removed by NN from the UI, but Ambari should not call > refreshnodes command on deletion to ensure slave is in "decommissioned and > dead" state, not "dead" > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > 30160274cf > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py > c9df2b9d54 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_windows.py > b3ac57864d > > ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/scripts/params_linux.py > 1581c2a144 > > ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/scripts/params_windows.py > 6c492d801a > > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py > 0b1215b43e > > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_windows.py > c2a02d79e1 > > ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/package/scripts/params_linux.py > 68d17f04e6 > > ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/package/scripts/params_windows.py > c2a02d79e1 > > ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/HDFS/package/scripts/params.py > 9cf163a7bd > > ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/YARN/package/scripts/params.py > 87b5992ce7 > > ambari-server/src/main/resources/stacks/HDP/2.0.6.GlusterFS/services/YARN/package/scripts/params.py > 16db0e432a > > ambari-server/src/main/resources/stacks/HDP/2.1.GlusterFS/services/YARN/package/scripts/params.py > bd188e9598 > > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java > 5fb236b50b > > contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/YARN/package/scripts/params_linux.py > da54b7c50f > > contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/YARN/package/scripts/params_windows.py > cac93ee121 > > > Diff: https://reviews.apache.org/r/61273/diff/2/ > > > Testing > ------- > > manual + unit tests > > > Thanks, > > Dmytro Sen > >
