----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61251/#review182085 -----------------------------------------------------------
Ship it! Ship It! - Robert Levas On Aug. 3, 2017, 4:14 a.m., Attila Magyar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61251/ > ----------------------------------------------------------- > > (Updated Aug. 3, 2017, 4:14 a.m.) > > > Review request for Ambari, Balázs Bence Sári, Robert Levas, and Sebastian > Toader. > > > Bugs: AMBARI-21613 > https://issues.apache.org/jira/browse/AMBARI-21613 > > > Repository: ambari > > > Description > ------- > > Dynamically determine what keytab files have been distributed to hosts. A > custom command should be available via the KERBEROS_CLIENT to query for the > keytab files installed on the relevant host. The communication between the > Ambari server and the agents should generate data needed to determine what > keytab files exist. > > > Diffs > ----- > > ambari-common/src/main/python/resource_management/core/resources/klist.py > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java > 1bc4c36 > > ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java > a08abab > > ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java > e5b7afd > > ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/metainfo.xml > 6a2dd09 > > ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/kerberos_client.py > 39fdcf5 > > ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/kerberos_common.py > fcd57af > > ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/metainfo.xml > 0e42bda > > ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/package/scripts/kerberos_client.py > b2cdaa6 > > ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/package/scripts/kerberos_common.py > abf58ee > > ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java > baa9bae > > ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java > 4508527 > ambari-server/src/test/python/stacks/2.2/KERBEROS/test_kerberos_client.py > f638845 > > > Diff: https://reviews.apache.org/r/61251/diff/4/ > > > Testing > ------- > > 1. > - created a cluster with kerberos enabled > - deleted a keytab file from a host > - regenerated missing keytabs > - checked that the deleted keytab file was recreated > > 2. > - regenerated missing keytabs when no keytab files were missing > - checked that no keytab file was regenerated > > 3. > - created a 15 nodes cluster on openstack with services: HDFS, YARN, > ZOOKEEPER, SPARK1, SPARK2, HIVE > - measured the time taken to regenerate all keytabs and only missing keytabs: > > regenerate missing keytabs only: 12.84 seconds (?=2.33) > regenerate all keytabs: 39.1 seconds (?=5.37) > > existing tests: > > server: > Ran 246 tests in 6.999s > OK > ---------------------------------------------------------------------- > Total run:1146 > Total errors:0 > Total failures:0 > > Results : > Tests run: 4816, Failures: 0, Errors: 0, Skipped: 35 > > agent: > Ran 470 tests in 98.589s > OK > > > Thanks, > > Attila Magyar > >
