----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61386/#review182115 -----------------------------------------------------------
Ship it! Ship It! - Vivek Ratnavel Subramanian On Aug. 2, 2017, 8:20 p.m., Aravindan Vijayan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61386/ > ----------------------------------------------------------- > > (Updated Aug. 2, 2017, 8:20 p.m.) > > > Review request for Ambari, Sumit Mohanty, Sid Wagle, Vivek Ratnavel > Subramanian, and Yusaku Sako. > > > Bugs: AMBARI-21640 > https://issues.apache.org/jira/browse/AMBARI-21640 > > > Repository: ambari > > > Description > ------- > > List of dashboards affected. > HDFS-Users > HBase - Tables > HBase - Users > Kafka - Topics > Nifi - Hosts > > > The problem here is that the 'cluster name' field added through AMBARI-20896 > was not handled correctly. Whenever the Cluster name is not present, it > appends an 'undefined' to the GET metrics URL causing wrong requests. > > > Diffs > ----- > > ambari-metrics/ambari-metrics-grafana/ambari-metrics/datasource.js b4a339e > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/HDF/grafana-nifi-hosts.json > 94aa285 > > > Diff: https://reviews.apache.org/r/61386/diff/1/ > > > Testing > ------- > > Manually tested all Grafana dashboards except Druid. (Including HDFS-Users, > HBase-Tables, HBase - Users, Storm-Topology, Kafka-Topics, Nifi-Hosts) > > > Thanks, > > Aravindan Vijayan > >
