----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61461/#review182305 -----------------------------------------------------------
Ship it! Ship It! - Robert Nettleton On Aug. 7, 2017, 4:03 p.m., Oliver Szabo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61461/ > ----------------------------------------------------------- > > (Updated Aug. 7, 2017, 4:03 p.m.) > > > Review request for Ambari, Attila Magyar, Robert Nettleton, and Sebastian > Toader. > > > Bugs: AMBARI-21670 > https://issues.apache.org/jira/browse/AMBARI-21670 > > > Repository: ambari > > > Description > ------- > > Some properties (like used port or protocol) for Log Search were not managed > by Spring. Those were loaded by PropertiesHelper -> that is not the proper > way to do it. To make the whole application managed by Spring, it affects the > servlet definitions as well. > > Also the patch contains a lot of cleanups. > > Changes: > - introduce spring boot in order to get rid of managing glasshish, jakson, > spring dependencies togather. > - use /static/ folder for static web files intead of webapps/apps (also > static content will be handled outside of jersey filter) > - move logsearch-env/logsearch_protocol and logsearch_ui_port to > logsearch.properties -> add a new property for SSL port. > - get rid of SSLUtil, use SSLConfigurer bean instead of it. > - get rid of Ldap authentication (not used) in Log Search > - update stack code (protocol + port changes) > - manage pid file by spring boot application (wont be needed to create the > pid file in run.sh script) > - add some new config objects > - update to jetty 9.4 > - pom.xml cleanup (get rid of non used profile) > > > Diffs > ----- > > ambari-logsearch/ambari-logsearch-logfeeder/build.properties 46979e5 > ambari-logsearch/ambari-logsearch-server/build.properties 1cd118a > ambari-logsearch/ambari-logsearch-server/pom.xml 4db1f61 > ambari-logsearch/ambari-logsearch-server/run.sh ea89947 > > ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/LogSearch.java > b1517df > > ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/common/ExternalServerClient.java > df00c15 > > ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/common/LogSearchConstants.java > a018dda > > ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/common/PropertiesHelper.java > 3505fe2 > > ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/common/XMLPropertiesHelper.java > 690a60f > > ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/ApiDocConfig.java > 1e61f22 > > ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/ApplicationConfig.java > 756252d > > ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/LogSearchConfigMapHolder.java > PRE-CREATION > > ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/LogSearchHttpConfig.java > PRE-CREATION > > ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/LogSearchJerseyResourceConfig.java > PRE-CREATION > > ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/LogSearchServletConfig.java > PRE-CREATION > > ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/LogSearchSpnegoConfig.java > PRE-CREATION > > ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/LogSearchSslConfig.java > PRE-CREATION > > ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/SecurityConfig.java > 5207dd0 > > ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/StaticResourceConfiguration.java > PRE-CREATION > > ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/configurer/LogSearchConfigConfigurer.java > 23b7430 > > ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/configurer/SslConfigurer.java > PRE-CREATION > > ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/util/SSLUtil.java > b0b893f > > ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/util/WebUtil.java > 36865ad > > ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/web/filters/LogsearchKRBAuthenticationFilter.java > ec3075c > > ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/web/listener/LogSearchSessionListener.java > 9fa5c80 > > ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/web/security/LdapProperties.java > 82e71fe > > ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/web/security/LdapPropertyName.java > 370c94b > > ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/web/security/LdapUtil.java > 6248e74 > > ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/web/security/LogsearchAbstractAuthenticationProvider.java > 1c7bf3b > > ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/web/security/LogsearchAuthenticationProvider.java > 711e3ec > > ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/web/security/LogsearchLdapAuthenticationProvider.java > ed4d7ef > > ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/web/security/LogsearchLdapBindAuthenticator.java > 10f7507 > > ambari-logsearch/ambari-logsearch-server/src/main/resources/default.properties > cd1f22a > ambari-logsearch/ambari-logsearch-server/src/main/resources/log4j.xml > dd85da8 > > ambari-logsearch/ambari-logsearch-server/src/main/resources/logsearch-admin-site.xml > 049172a > > ambari-logsearch/ambari-logsearch-server/src/main/resources/logsearch.properties > 3e59163 > > ambari-logsearch/ambari-logsearch-server/src/main/resources/swagger/swagger.html > 33346d3 > ambari-logsearch/ambari-logsearch-server/src/main/scripts/run.sh b8fd6c4 > > ambari-logsearch/ambari-logsearch-server/src/test/java/org/apache/ambari/logsearch/web/security/LogsearchAuthenticationProviderTest.java > c6a5ba5 > > ambari-logsearch/ambari-logsearch-server/src/test/java/org/apache/ambari/logsearch/web/security/LogsearchLdapAuthenticationProviderTest.java > c6af3e2 > ambari-logsearch/ambari-logsearch-web/build.properties d943501 > ambari-logsearch/ambari-logsearch-web/pom.xml 5f44553 > ambari-logsearch/docker/logsearch-docker.sh fc3524d > ambari-logsearch/docker/test-config/logsearch/log4j.xml d0e26ed > ambari-logsearch/docker/test-config/logsearch/logsearch-env.sh 6409f0f > ambari-logsearch/docker/test-config/logsearch/logsearch-https.properties > 782b16a > > ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LoggingRequestHelperFactoryImpl.java > 4d0ee89 > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog300.java > 5f6640a > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/alerts.json > d2926c8 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-env.xml > f1e871d > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-properties.xml > be586fd > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py > 1b77999 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/logsearch-env.sh.j2 > f21b7be > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/quicklinks/quicklinks.json > f3f376a > > ambari-server/src/test/java/org/apache/ambari/server/controller/logging/LoggingRequestHelperFactoryImplTest.java > b759738 > ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logsearch.py > afdc42f > ambari-server/src/test/python/stacks/2.4/configs/default.json 1863c02 > ambari-server/src/test/python/unitTests.py bff8959 > ambari-web/app/data/configs/services/logsearch_properties.js 3b1a9e8 > > > Diff: https://reviews.apache.org/r/61461/diff/2/ > > > Testing > ------- > > done. > > > Thanks, > > Oliver Szabo > >
