-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61500/
-----------------------------------------------------------

(Updated Aug. 9, 2017, 10:38 a.m.)


Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.


Changes
-------

Update for comments.  Post-loop the groups looking for ones to remove if a 
service check shouldn't run.


Bugs: AMBARI-21679
    https://issues.apache.org/jira/browse/AMBARI-21679


Repository: ambari


Description
-------

There are two issues with Service Checks and patches:

1. A service check grouping can be orchestrated one right after the other if 
the grouping in between them has no processing.
2. A service check grouping can be orchestrated before any components have been 
scheduled.


Diffs (updated)
-----

  ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 
07012961af 
  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java
 3deb7c866e 
  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Grouping.java
 fed5b77942 
  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ServiceCheckGrouping.java
 6a085f331f 
  
ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java
 24a3fa2ce2 
  
ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test_checks.xml
 f82b0258de 


Diff: https://reviews.apache.org/r/61500/diff/2/

Changes: https://reviews.apache.org/r/61500/diff/1-2/


Testing
-------

Manual.  Automated:

Tests run: 4481, Failures: 0, Errors: 0, Skipped: 31

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 21:58.183s
[INFO] Finished at: Tue Aug 08 11:36:30 EDT 2017
[INFO] Final Memory: 57M/637M
[INFO] ------------------------------------------------------------------------


Thanks,

Nate Cole

Reply via email to