-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61542/#review182548
-----------------------------------------------------------


Ship it!




We already have a class handling this event - StackUpgradeFinishListener - you 
can clear the RCO stuff in there. This prevents you from needing to add the 
event publisher to the cache. If you want to keep the code the way it is, you'd 
need to do this:

@Inject
VersionEventPublisher versionEventPublisher;

...
eventPublisher.register(this);

- Jonathan Hurley


On Aug. 9, 2017, 7:05 p.m., Sid Wagle wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61542/
> -----------------------------------------------------------
> 
> (Updated Aug. 9, 2017, 7:05 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmytro Sen, Jonathan Hurley, 
> and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-21695
>     https://issues.apache.org/jira/browse/AMBARI-21695
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> org.apache.ambari.server.metadata.CachedRoleCommandOrderProvider#getRoleCommandOrder(org.apache.ambari.server.state.Cluster)
> 
> This method caches the RCO for the stack which is never cleared. Since the BI 
> stack does not have Accumulo service the RCO is not honored resulting in 
> ACCUMULO service not starting after the express upgrade when ACCUMULO is 
> added.
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metadata/CachedRoleCommandOrderProvider.java
>  49abc66 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java
>  d531460 
>   ambari-server/src/main/resources/scripts/configs.py 40a8324 
> 
> 
> Diff: https://reviews.apache.org/r/61542/diff/2/
> 
> 
> Testing
> -------
> 
> UpgradeActionTest unit tests are green.
> 
> 
> File Attachments
> ----------------
> 
> AMBARI-21695-1.patch
>   
> https://reviews.apache.org/media/uploaded/files/2017/08/09/eadc72ba-a0ce-4b99-9f57-f5230a7d165b__AMBARI-21695-1.patch
> 
> 
> Thanks,
> 
> Sid Wagle
> 
>

Reply via email to