-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61525/#review182584
-----------------------------------------------------------


Ship it!




Ship It!

- Jonathan Hurley


On Aug. 10, 2017, 2:29 a.m., Mugdha Varadkar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61525/
> -----------------------------------------------------------
> 
> (Updated Aug. 10, 2017, 2:29 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, and Jonathan 
> Hurley.
> 
> 
> Bugs: AMBARI-21690
>     https://issues.apache.org/jira/browse/AMBARI-21690
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Currently get_stack_version only accepts stack version with -buildnumber at 
> the end. 
> Need to change stack_version pattern match for stack_version without 
> -buildnumber.
> 
> For cross stack upgrade from IOP to HDP, if user restart services after 
> Ambari upgrade ie before upgrading to HDP stack 2.6, the get_stack_version 
> returns None. This affects Ranger-related functionality which depends on 
> stack_version for generating file path.
> 
> The problem occured for cluster with IOP - 4.2.0.0 with latest Ambari, which 
> doesn't have -buildnumber at the end, so 4.2.0.0 is not matched and 
> stack_version=None.
> 
> 
> Diffs
> -----
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/get_stack_version.py
>  7274a59 
> 
> 
> Diff: https://reviews.apache.org/r/61525/diff/2/
> 
> 
> Testing
> -------
> 
> Tested:
> 1)Services restart after ambari upgrade with IOP 4.2.0.0
> 2)Fresh installs with HDP.
> 3)EU from IOP to HDP-2.6.x and HDP-2.6.x to HDP-2.6.y
> 
> Unit test report:
> Ran 274 tests in 6.820s
> 
> OK
> ----------------------------------------------------------------------
> Total run:1162
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Reply via email to