> On Сер. 10, 2017, 9:53 після полудня, Sid Wagle wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
> > Lines 1803 (patched)
> > <https://reviews.apache.org/r/61582/diff/1/?file=1795198#file1795198line1803>
> >
> >     Can you add comment why we need this, we should mention a TODO to find 
> > reason for this workaround.

Ok, i will add comment during commit. Also i'm planning to resolve this issue 
asap, so not sure this comment is needed. By the way, these changes are not so 
bad, here we are doing changes only for entities that need changes, not for all.


- Vitalyi


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61582/#review182631
-----------------------------------------------------------


On Сер. 10, 2017, 9:41 після полудня, Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61582/
> -----------------------------------------------------------
> 
> (Updated Сер. 10, 2017, 9:41 після полудня)
> 
> 
> Review request for Ambari, Myroslav Papirkovskyy, Sumit Mohanty, and Sid 
> Wagle.
> 
> 
> Bugs: AMBARI-21173
>     https://issues.apache.org/jira/browse/AMBARI-21173
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Change Yarn-site.xml to some custom configs and restart Yarn
> Restore it back to the origin config; Restart fails
> {Code}
> Traceback (most recent call last):
>   File 
> "/var/lib/ambari-agent/cache/common-services/YARN/3.0.0.3.0/package/scripts/nodemanager.py",
>  line 106, in <module>
>     Nodemanager().execute()
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
>  line 330, in execute
>     method(env)
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
>  line 835, in restart
>     self.stop(env, upgrade_type=upgrade_type)
>   File 
> "/var/lib/ambari-agent/cache/common-services/YARN/3.0.0.3.0/package/scripts/nodemanager.py",
>  line 45, in stop
>     import params
>   File 
> "/var/lib/ambari-agent/cache/common-services/YARN/3.0.0.3.0/package/scripts/params.py",
>  line 29, in <module>
>     from params_linux import *
>   File 
> "/var/lib/ambari-agent/cache/common-services/YARN/3.0.0.3.0/package/scripts/params_linux.py",
>  line 39, in <module>
>     import status_params
>   File 
> "/var/lib/ambari-agent/cache/common-services/YARN/3.0.0.3.0/package/scripts/status_params.py",
>  line 46, in <module>
>     yarn_pid_dir = format("{yarn_pid_dir_prefix}/{yarn_user}")
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/libraries/functions/format.py",
>  line 95, in format
>     return ConfigurationFormatter().format(format_string, args, **result)
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/libraries/functions/format.py",
>  line 59, in format
>     result_protected = self.vformat(format_string, args, all_params)
>   File "/usr/lib64/python2.7/string.py", line 549, in vformat
>     result = self._vformat(format_string, args, kwargs, used_args, 2)
>   File "/usr/lib64/python2.7/string.py", line 582, in _vformat
>     result.append(self.format_field(obj, format_spec))
>   File "/usr/lib64/python2.7/string.py", line 599, in format_field
>     return format(value, format_spec)
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/libraries/script/config_dictionary.py",
>  line 73, in __getattr__
>     raise Fail("Configuration parameter '" + self.name + "' was not found in 
> configurations dictionary!")
> resource_management.core.exceptions.Fail: Configuration parameter 'yarn-env' 
> was not found in configurations dictionary!
> {Code}
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
>  06b6217 
> 
> 
> Diff: https://reviews.apache.org/r/61582/diff/1/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Reply via email to