-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61587/
-----------------------------------------------------------
Review request for Ambari, Sumit Mohanty and Sid Wagle.
Bugs: AMBARI-21706
https://issues.apache.org/jira/browse/AMBARI-21706
Repository: ambari
Description
-------
Whenever an empty host list is passed to the HostService or the
RecommendationService, the exception messages do not have enough information
about the problem.
Exception Traces
Host Service
10 Aug 2017 09:49:17,123 ERROR [ambari-client-thread-593] QueryParser:115 -
Lowercase host_name value in expression failed with error:java.lang.NullPoi
nterException
10 Aug 2017 09:49:17,125 ERROR [ambari-client-thread-593] Request:147 - Unable
to compile query predicate: IN operator is missing a required right operand.
Recommendation Service
java.lang.ClassCastException: java.util.LinkedHashSet cannot be cast to
java.util.List
at
org.apache.ambari.server.controller.internal.StackAdvisorResourceProvider.prepareStackAdvisorRequest(StackAdvisorResourceProvider.java:110)
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/api/predicate/QueryParser.java
7386813
ambari-server/src/main/java/org/apache/ambari/server/api/predicate/operators/InOperator.java
629c3fc
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackAdvisorResourceProvider.java
5bb52c2
ambari-server/src/test/java/org/apache/ambari/server/api/predicate/QueryParserTest.java
cf332e7
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackAdvisorResourceProviderTest.java
5a3c8af
Diff: https://reviews.apache.org/r/61587/diff/1/
Testing
-------
Manually tested.
mvn clean test on ambari-server.
Thanks,
Aravindan Vijayan
