----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61605/#review182864 -----------------------------------------------------------
Ship it! ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertUri.java Lines 36-37 (patched) <https://reviews.apache.org/r/61605/#comment258810> Seems like a Set<Integer> would be more appropriate - Nate Cole On Aug. 14, 2017, 9:23 a.m., Eugene Chekanskiy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61605/ > ----------------------------------------------------------- > > (Updated Aug. 14, 2017, 9:23 a.m.) > > > Review request for Ambari, Jonathan Hurley and Nate Cole. > > > Bugs: AMBARI-21712 > https://issues.apache.org/jira/browse/AMBARI-21712 > > > Repository: ambari > > > Description > ------- > > Sometimes WEB alert can guaranty that codes more than 400 will guaranty that > WEB working properly, but ambari has hardcoded values of acceptable HTTP > codes. This patch allows for WEB alerts to define custom list of acceptable > codes that will be accepted alongside with codes less than 400. > > > Diffs > ----- > > ambari-agent/src/main/python/ambari_agent/alerts/base_alert.py add29fc > ambari-agent/src/main/python/ambari_agent/alerts/web_alert.py 8ce4405 > ambari-agent/src/test/python/ambari_agent/TestAlerts.py 64479a2 > > ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertUri.java > dea105e > > > Diff: https://reviews.apache.org/r/61605/diff/2/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Eugene Chekanskiy > >
