----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61619/#review182886 -----------------------------------------------------------
Ship it! ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/DistributeRepositoriesActionListener.java Lines 168-175 (patched) <https://reviews.apache.org/r/61619/#comment258823> It's so much cleaner!!!! - Jonathan Hurley On Aug. 14, 2017, 11:39 a.m., Nate Cole wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61619/ > ----------------------------------------------------------- > > (Updated Aug. 14, 2017, 11:39 a.m.) > > > Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley. > > > Bugs: AMBARI-21719 > https://issues.apache.org/jira/browse/AMBARI-21719 > > > Repository: ambari > > > Description > ------- > > install_packages should be fixed to use the correct command structure and > respond using the repo_id. The current implementation is still using > roleParams > > > Diffs > ----- > > > ambari-common/src/main/python/resource_management/libraries/functions/repository_util.py > f1edbec265 > > ambari-server/src/main/java/org/apache/ambari/server/bootstrap/DistributeRepositoriesStructuredOutput.java > 0cf2d78b3a > > ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/DistributeRepositoriesActionListener.java > c3c8f67ad0 > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/RepositoryVersionHelper.java > 8bf2a24c37 > ambari-server/src/main/resources/custom_actions/scripts/install_packages.py > 9c08bf9379 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py > bd86b50b5d > > ambari-server/src/test/java/org/apache/ambari/server/agent/HeartbeatProcessorTest.java > 37e68d0d6e > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java > 41c83e4600 > ambari-server/src/test/python/custom_actions/TestInstallPackages.py > 134d9aa290 > > ambari-server/src/test/python/custom_actions/configs/install_packages_config.json > c6b1c0c938 > > > Diff: https://reviews.apache.org/r/61619/diff/2/ > > > Testing > ------- > > Manual. Automated: > > Tests run: 4397, Failures: 0, Errors: 0, Skipped: 30 > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 23:57.511s > [INFO] Finished at: Mon Aug 14 14:00:10 EDT 2017 > [INFO] Final Memory: 76M/2037M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Nate Cole > >
