----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61622/#review182912 -----------------------------------------------------------
ambari-common/src/main/python/resource_management/libraries/functions/component_version.py Lines 21 (patched) <https://reviews.apache.org/r/61622/#comment258850> it looks that script getting more and more arguments required to be parsed and a lot of modules need to be imported like linux_params. Why we cant create class named ScriptParams for example and put all params there with initializing that class on script instance creation. In such way we can decrease amount of work on each script we have and would need in the future with likely good side effect - keeping same functionality at the same place. But it looks like a separate issue - Dmytro Grinenko On Aug. 14, 2017, 9:01 p.m., Jonathan Hurley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61622/ > ----------------------------------------------------------- > > (Updated Aug. 14, 2017, 9:01 p.m.) > > > Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, and Nate Cole. > > > Bugs: AMBARI-21722 > https://issues.apache.org/jira/browse/AMBARI-21722 > > > Repository: ambari > > > Description > ------- > > The command generators in Ambari are sending down the > {{KeyName.CURRENT_VERSION}} ({{current_version}}) property in the JSON to the > agents. This is being used to determine the "current cluster version" which > doesn't really exist anymore: > > {code:title=stack_features.py} > # something like 2.4.0.0-1234 > # (or None if this is a cluster install and it hasn't been calculated yet) > current_cluster_version = default("/hostLevelParams/current_version", None) > {code} > > This really needs to be calculated from the service's repository version > instead. > > > Diffs > ----- > > > ambari-common/src/main/python/resource_management/libraries/functions/component_version.py > PRE-CREATION > > ambari-common/src/main/python/resource_management/libraries/functions/copy_tarball.py > 31a9be414c > > ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py > 3fcce820ca > > ambari-common/src/main/python/resource_management/libraries/functions/upgrade_summary.py > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ExecutionCommandWrapper.java > e4b2540696 > > ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java > 9b6b2f58dd > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > 7e26fd790d > > ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContext.java > e6a420e090 > > ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py > c9c66ac1dd > > ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py > 3773918ef7 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py > f94248bd8b > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_upgrade.py > 17db489a03 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service.py > 22b4061d5d > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py > d46b6ce721 > > ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/kafka.py > e6d73393f5 > > ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/kafka_broker.py > 266bb429ec > > ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py > 8aa4fc26e4 > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py > 9b0bbfc836 > > ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py > aa5bc308fe > > ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5/package/scripts/params_linux.py > b8e8f78df1 > > ambari-server/src/main/resources/stacks/BigInsights/4.0/services/HIVE/package/scripts/hive_metastore.py > 88bb2e09e8 > > ambari-server/src/main/resources/stacks/BigInsights/4.0/services/HIVE/package/scripts/hive_server_upgrade.py > 318fcca23d > > ambari-server/src/main/resources/stacks/BigInsights/4.0/services/HIVE/package/scripts/params.py > e5fe128873 > > ambari-server/src/main/resources/stacks/BigInsights/4.0/services/KAFKA/package/scripts/kafka_broker.py > cb5954e306 > > ambari-server/src/main/resources/stacks/BigInsights/4.0/services/KAFKA/package/scripts/params.py > bc197042b1 > > ambari-server/src/main/resources/stacks/BigInsights/4.0/services/SOLR/package/scripts/params.py > d5d90f615b > > ambari-server/src/main/resources/stacks/BigInsights/4.0/services/SOLR/package/scripts/solr_service.py > 105aac63fe > > ambari-server/src/main/resources/stacks/BigInsights/4.0/services/SOLR/package/scripts/solr_upgrade.py > fa2feb0e61 > > ambari-server/src/main/resources/stacks/BigInsights/4.0/services/ZOOKEEPER/package/scripts/params.py > e9b8144b45 > > ambari-server/src/main/resources/stacks/BigInsights/4.0/services/ZOOKEEPER/package/scripts/zookeeper.py > 0cb62bf596 > > ambari-server/src/main/resources/stacks/BigInsights/4.0/services/ZOOKEEPER/package/scripts/zookeeper_service.py > 1dc24cd00c > > ambari-server/src/main/resources/stacks/BigInsights/4.2.5/hooks/after-INSTALL/scripts/params.py > 4f589f8ec0 > > ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/SOLR/package/scripts/params.py > b708026369 > > ambari-server/src/main/resources/stacks/BigInsights/4.2/services/HBASE/package/scripts/params.py > 2c672aaf0c > > ambari-server/src/main/resources/stacks/BigInsights/4.2/services/HIVE/package/scripts/hive_metastore.py > adfbead726 > > ambari-server/src/main/resources/stacks/BigInsights/4.2/services/HIVE/package/scripts/hive_server_upgrade.py > 9c862a5891 > > ambari-server/src/main/resources/stacks/BigInsights/4.2/services/HIVE/package/scripts/params_linux.py > caba6eeb1b > > ambari-server/src/main/resources/stacks/BigInsights/4.2/services/KAFKA/package/scripts/kafka_broker.py > 772ecad66a > > ambari-server/src/main/resources/stacks/BigInsights/4.2/services/KAFKA/package/scripts/params.py > 2ae0e426f0 > > ambari-server/src/main/resources/stacks/BigInsights/4.2/services/KNOX/package/scripts/params.py > 89f801ab2f > > ambari-server/src/main/resources/stacks/BigInsights/4.2/services/SOLR/package/scripts/params.py > 8e901ffd11 > > ambari-server/src/main/resources/stacks/BigInsights/4.2/services/SOLR/package/scripts/solr_upgrade.py > 55a61b621b > > ambari-server/src/main/resources/stacks/BigInsights/4.2/services/SPARK/package/scripts/params.py > 8ec5af8226 > > ambari-server/src/main/resources/stacks/BigInsights/4.2/services/ZOOKEEPER/package/scripts/params.py > e9b8144b45 > > ambari-server/src/main/resources/stacks/BigInsights/4.2/services/ZOOKEEPER/package/scripts/zookeeper.py > 9253f436bb > > ambari-server/src/main/resources/stacks/BigInsights/4.2/services/ZOOKEEPER/package/scripts/zookeeper_service.py > 1dc24cd00c > ambari-server/src/test/python/TestStackFeature.py 6e8bcec732 > ambari-server/src/test/python/TestUpgradeSummary.py PRE-CREATION > ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py > 6caadd3fd1 > ambari-server/src/test/python/stacks/2.0.6/configs/nn_eu.json 3aadf2ccc2 > ambari-server/src/test/python/stacks/2.0.6/configs/nn_eu_standby.json > 2d48ff6d5f > ambari-server/src/test/python/stacks/2.0.6/configs/secured.json 76a110e6bd > > ambari-server/src/test/python/stacks/2.0.6/hooks/after-INSTALL/test_after_install.py > 805a7bc0a3 > ambari-server/src/test/python/stacks/2.1/FALCON/test_falcon_client.py > 9de2156aa7 > ambari-server/src/test/python/stacks/2.1/FALCON/test_falcon_server.py > 2c877c81d8 > ambari-server/src/test/python/stacks/2.1/FALCON/test_service_check.py > 6519e3c314 > ambari-server/src/test/python/stacks/2.1/HIVE/test_hive_metastore.py > 24fb0d9ba8 > > ambari-server/src/test/python/stacks/2.1/configs/hive-metastore-upgrade.json > 021695b575 > ambari-server/src/test/python/stacks/2.2/KNOX/test_knox_gateway.py > 8cdbb2ed87 > ambari-server/src/test/python/stacks/2.2/configs/knox_upgrade.json > 1805c3bbd7 > ambari-server/src/test/python/stacks/2.3/configs/storm_default.json > 351025db38 > ambari-server/src/test/python/stacks/2.3/configs/storm_default_secure.json > daa903025c > ambari-server/src/test/python/stacks/2.5/configs/ranger-admin-default.json > fb77531c6c > ambari-server/src/test/python/stacks/2.5/configs/ranger-admin-secured.json > 7f1e5494d3 > ambari-server/src/test/python/stacks/2.5/configs/ranger-kms-default.json > cafbeded90 > ambari-server/src/test/python/stacks/2.5/configs/ranger-kms-secured.json > bcadd039c4 > ambari-server/src/test/python/stacks/2.6/configs/ranger-admin-default.json > e5abe32430 > ambari-server/src/test/python/stacks/2.6/configs/ranger-admin-secured.json > 64e7d5289e > > contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/hooks/after-INSTALL/scripts/params.py > 819d8f7cfd > > contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/HIVE/package/scripts/params_linux.py > 9d79e1275f > > > Diff: https://reviews.apache.org/r/61622/diff/1/ > > > Testing > ------- > > ---------------------------------------------------------------------- > Total run:1155 > Total errors:0 > Total failures:0 > > > Thanks, > > Jonathan Hurley > >
