----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61695/#review183133 -----------------------------------------------------------
Ship it! Ship It! - Nate Cole On Aug. 16, 2017, 3:09 p.m., Jonathan Hurley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61695/ > ----------------------------------------------------------- > > (Updated Aug. 16, 2017, 3:09 p.m.) > > > Review request for Ambari, Dmytro Grinenko and Nate Cole. > > > Bugs: AMBARI-21734 > https://issues.apache.org/jira/browse/AMBARI-21734 > > > Repository: ambari > > > Description > ------- > > During a patch reversion, the associated repository of the upgrade was the > target. This seems wrong as the associated version on a downgrade is the > single repo that you're coming from. > > When this was changed, it caused problems setting the desired repository, so > something is definitely wrong here. > > Also, there were some leftover Python changes related to reversion/downgrades > which I included in this. > > > Diffs > ----- > > > ambari-common/src/main/python/resource_management/libraries/functions/constants.py > 6ae71ef9f5 > > ambari-common/src/main/python/resource_management/libraries/functions/upgrade_summary.py > f2f5e425fa > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java > 4a28f5694c > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeHistoryEntity.java > 0f7ac720b6 > > ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContext.java > 3d7f5336d3 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py > b75ff132fc > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_upgrade.py > 9121923a18 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py > 886156a833 > > ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/kafka.py > 101cd409a0 > > ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/kafka_broker.py > 769e6ec4be > > ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py > 349ff5cb02 > > ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/upgrade.py > e79a8ad218 > > ambari-server/src/main/resources/stacks/BigInsights/4.0/properties/stack_features.json > bf00f132aa > > ambari-server/src/main/resources/stacks/BigInsights/4.0/services/HIVE/package/scripts/hive_metastore.py > 7728ac6b11 > > ambari-server/src/main/resources/stacks/BigInsights/4.0/services/HIVE/package/scripts/hive_server_upgrade.py > 0105a7d08e > > ambari-server/src/main/resources/stacks/BigInsights/4.0/services/HIVE/package/scripts/params.py > e9d62b188c > > ambari-server/src/main/resources/stacks/BigInsights/4.0/services/KAFKA/package/scripts/kafka_broker.py > b8d44f045f > > ambari-server/src/main/resources/stacks/BigInsights/4.0/services/KAFKA/package/scripts/params.py > 799866a3b7 > > ambari-server/src/main/resources/stacks/BigInsights/4.0/services/KAFKA/package/scripts/upgrade.py > e405cb54f3 > > ambari-server/src/main/resources/stacks/BigInsights/4.2/services/HIVE/package/scripts/hive_metastore.py > 2705e5a2b7 > > ambari-server/src/main/resources/stacks/BigInsights/4.2/services/HIVE/package/scripts/hive_server_upgrade.py > 71263d4a04 > > ambari-server/src/main/resources/stacks/BigInsights/4.2/services/HIVE/package/scripts/params_linux.py > 770d3c5617 > > ambari-server/src/main/resources/stacks/BigInsights/4.2/services/KAFKA/package/scripts/kafka_broker.py > 16e7039f95 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json > 973d9dd3a3 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java > aa216f74fc > > ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeContextTest.java > 629ea9bb76 > ambari-server/src/test/python/TestUpgradeSummary.py 614dcd2d81 > ambari-server/src/test/python/stacks/2.1/HIVE/test_hive_metastore.py > ac5d6ae28f > > contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/HIVE/package/scripts/hive_metastore.py > a49bbd9458 > > contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/HIVE/package/scripts/hive_server_upgrade.py > 9aa3d96983 > > contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/HIVE/package/scripts/params_linux.py > 1e4487d02a > > > Diff: https://reviews.apache.org/r/61695/diff/1/ > > > Testing > ------- > > PENDING... > > > Thanks, > > Jonathan Hurley > >