----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61856/#review183641 -----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java Lines 160 (patched) <https://reviews.apache.org/r/61856/#comment259703> Why doesn't this check is service exists or not? ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java Lines 168 (patched) <https://reviews.apache.org/r/61856/#comment259704> Is this within a transaction boundary? ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog260Test.java Lines 48 (patched) <https://reviews.apache.org/r/61856/#comment259702> Make sure to run checkstyle on this. - Sid Wagle On Aug. 23, 2017, 6:49 p.m., Vitalyi Brodetskyi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61856/ > ----------------------------------------------------------- > > (Updated Aug. 23, 2017, 6:49 p.m.) > > > Review request for Ambari, Myroslav Papirkovskyy and Sid Wagle. > > > Bugs: AMBARI-21795 > https://issues.apache.org/jira/browse/AMBARI-21795 > > > Repository: ambari > > > Description > ------- > > If user has deleted services, after upgrade db consistency check will throw > warnings about unmapped configs. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java > 40049c0 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterConfigEntity.java > 34f3034 > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java > 319bf53 > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java > 7fc392d > ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 9cdf8e8 > ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql d616e77 > ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 0530651 > ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 1d16eb6 > ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql da23e95 > ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql e410555 > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog260Test.java > 44b5d91 > > > Diff: https://reviews.apache.org/r/61856/diff/2/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Vitalyi Brodetskyi > >
