> On Aug. 24, 2017, 1:25 p.m., Robert Levas wrote: > > Are there no DDL file changes?
There are, but you need to pay to see them :) Thanks - forgot to include them. Attached now. - Jonathan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61890/#review183749 ----------------------------------------------------------- On Aug. 24, 2017, 1:05 p.m., Jonathan Hurley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61890/ > ----------------------------------------------------------- > > (Updated Aug. 24, 2017, 1:05 p.m.) > > > Review request for Ambari, Dmitro Lisnichenko, Nate Cole, and Robert Levas. > > > Bugs: AMBARI-21806 > https://issues.apache.org/jira/browse/AMBARI-21806 > > > Repository: ambari > > > Description > ------- > > Many tables have begun referencing {{repo_version}} since a simple > {{version}} string is no longer sufficient to properly identify a repository. > However, we allow a {{RepsitoryVersionEntity}} to be removed if it is in the > following states: > > - {{INIT}} > - {{INSTALL_FAILED}} > - {{OUT_OF_SYNC}} > > The issue with removing the entities is that this would also force us to > remove things like upgrades, service component versions, etc. Here are some > options: > > # Allow repository versions in {{INIT}} and {{INSTALL_FAILED}} to be removed, > but for other states we'd need to keep it in the DB for history and perhaps > add a {{hidden}} column. This would keep the referential integrity. > # Allow the removal of repository versions, but warn that it will also remove > things like upgrades. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java > 34b7b9263e > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java > f84f3a433e > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java > 7fc392d584 > ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 9cdf8e8bd3 > ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql d616e778a8 > ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 0530651d39 > ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 1d16eb611c > ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql > da23e95ad3 > ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql e410555149 > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog260Test.java > 44b5d914fd > > > Diff: https://reviews.apache.org/r/61890/diff/2/ > > > Testing > ------- > > [WARNING] Tests run: 4848, Failures: 0, Errors: 0, Skipped: 35 > [INFO] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 27:45 min > [INFO] Finished at: 2017-08-24T12:31:49-04:00 > [INFO] Final Memory: 59M/1210M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Jonathan Hurley > >
