-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61911/
-----------------------------------------------------------
(Updated Aug. 25, 2017, 9:51 a.m.)
Review request for Ambari, Balázs Bence Sári, Jayush Luniya, and Robert Levas.
Changes
-------
+extract method, -duplication
Bugs: AMBARI-21812
https://issues.apache.org/jira/browse/AMBARI-21812
Repository: ambari
Description
-------
Running: ambari-server install-mpack --mpack=/path/to/mympack.tgz --verbose
Fails with:
Traceback (most recent call last):
File "/usr/sbin/ambari-server.py", line 754, in <module>
mainBody()
File "/usr/sbin/ambari-server.py", line 725, in mainBody
main(options, args, parser)
File "/usr/sbin/ambari-server.py", line 678, in main
action_obj.execute()
File "/usr/sbin/ambari-server.py", line 69, in execute
self.fn(*self.args, **self.kwargs)
File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line
764, in install_mpack
(mpack_metadata, mpack_name, mpack_version, mpack_staging_dir,
mpack_archive_path) = _install_mpack(options, replay_mode)
File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line
620, in _install_mpack
tmp_root_dir = expand_mpack(tmp_archive_path)
File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line
139, in expand_mpack
archive_root_dir = get_archive_root_dir(archive_path)
File
"/usr/lib/python2.6/site-packages/resource_management/libraries/functions/tar_archive.py",
line 70, in get_archive_root_dir
if archive.endswith('.tar.gz') or path.endswith('.tgz'):
Diffs (updated)
-----
ambari-common/src/main/python/resource_management/libraries/functions/tar_archive.py
c682c3e
Diff: https://reviews.apache.org/r/61911/diff/2/
Changes: https://reviews.apache.org/r/61911/diff/1-2/
Testing
-------
- installed an mpack with tgz extension successfully
Thanks,
Attila Magyar
