----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61898/#review183838 -----------------------------------------------------------
ambari-infra/ambari-infra-solr-client/src/main/python/solr_collection_data_manager.py Lines 1 (patched) <https://reviews.apache.org/r/61898/#comment259907> i think we do not need the solr_collection prefix for the script name, it can be only data_manager or data_archiver (if we could only delete records without archiving, data_manager is the correct one, otherwise data_archiver can be enogh) - Oliver Szabo On Aug. 24, 2017, 11:42 p.m., Miklos Gergely wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61898/ > ----------------------------------------------------------- > > (Updated Aug. 24, 2017, 11:42 p.m.) > > > Review request for Ambari, Oliver Szabo and Robert Nettleton. > > > Bugs: AMBARI-21810 > https://issues.apache.org/jira/browse/AMBARI-21810 > > > Repository: ambari > > > Description > ------- > > This script allows the user to set an end date, and save all the previous log > entries into HDFS or S3 > > > Diffs > ----- > > ambari-infra/ambari-infra-solr-client/build.xml 9b8b6cc > ambari-infra/ambari-infra-solr-client/pom.xml 3818aba > > ambari-infra/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/S3Uploader.java > PRE-CREATION > > ambari-infra/ambari-infra-solr-client/src/main/python/solr_collection_data_manager.py > PRE-CREATION > > > Diff: https://reviews.apache.org/r/61898/diff/1/ > > > Testing > ------- > > Tested on local cluster with > - SSL > - kerberos > - interrupted, then restarted script > - HDFS > - S3 > - the combinations of the above > > > Thanks, > > Miklos Gergely > >
