-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61917/
-----------------------------------------------------------
(Updated Aug. 29, 2017, 7:31 p.m.)
Review request for Ambari, Jayush Luniya and Madhuvanthi Radhakrishnan.
Changes
-------
Renamed fn. 'findServiceName()' to appropriate name 'findServiceName()' as per
Jayush's comment.
Bugs: AMBARI-21824
https://issues.apache.org/jira/browse/AMBARI-21824
Repository: ambari
Description
-------
ServiceGroup was a new sub-resource added for cluster in AMBARI-21594.
This change involves :
- moving **Services** which was earlier a sub-resource of **Cluster** under
**ServiceGroup** now, and
- using **Servicegroup** while doing Creation, Update and retrieval of
**HostComponents** and **ServiceComponents**.
The new API calls will be the following:
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
**Service:**
http://<hostname>:<port>/api/v1/clusters/<clusterName>/**servicegroups/<ServiceGroupName>**/services
http://<hostname>:<port>/api/v1/clusters/<clusterName>/**servicegroups/<ServiceGroupName>**/services/<ServiceName>
**ServiceComponent:**
http://<hostname>:<port>/api/v1/clusters/<clusterName>/**servicegroups/<ServiceGroupName>**/services/<ServiceName>/components/
http://<hostname>:<port>/api/v1/clusters/<clusterName>/**servicegroups/<ServiceGroupName>**/services/<ServiceName>/components/ZOOKEEPER_SERVER
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
**HostComponent:** (API remains same, but has notion of servicegroup in Ambari
backend)
http://<hostname>:<port>/api/v1/clusters/c1/hosts/<HostName>/host_components/
http://<hostname>:<port>/api/v1/clusters/c1/hosts/<HostName>/host_components/<HostComponentName>
- The change also includes UI changes as well, which create a **default
ServiceGroup named 'core'**, and all services created goes under it.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/ServiceComponentNotFoundException.java
8f25cb1
ambari-server/src/main/java/org/apache/ambari/server/ServiceNotFoundException.java
6b18c09
ambari-server/src/main/java/org/apache/ambari/server/StateRecoveryManager.java
03990a2
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java
d83a5d1
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java
2690008
ambari-server/src/main/java/org/apache/ambari/server/agent/StatusCommand.java
e8c0b05
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterResourceDefinition.java
24c2810
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ComponentResourceDefinition.java
2a98a9c
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ServiceGroupResourceDefinition.java
f686851
ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
80bd58d
ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterService.java
c38489d
ambari-server/src/main/java/org/apache/ambari/server/api/services/ComponentService.java
b489a15
ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceGroupService.java
aa1270a
ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceService.java
6ab2704
ambari-server/src/main/java/org/apache/ambari/server/checks/ComponentsInstallationCheck.java
988fc78
ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
b440c93
ambari-server/src/main/java/org/apache/ambari/server/checks/SecondaryNamenodeDeletedCheck.java
543df26
ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesUpCheck.java
6b03249
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java
663d857
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
ca84826
ambari-server/src/main/java/org/apache/ambari/server/controller/ClusterResponse.java
3f75971
ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
e09f433
ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceComponentHostRequest.java
94b5985
ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceComponentHostResponse.java
7b75e06
ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceComponentRequest.java
3a65ff8
ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceComponentResponse.java
9bd3e44
ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceRequest.java
3b3c940
ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceResponse.java
ed1832a
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java
0242d7c
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
166fc5f
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ComponentResourceProvider.java
2df3b00
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java
aaf4656
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java
01e0aac
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStatusHelper.java
f94b979
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java
89f75f3
ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LoggingSearchPropertyProvider.java
64261b3
ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/DatabaseChecker.java
95352bf
ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/DefaultServiceCalculatedState.java
5e02a64
ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/FlumeServiceCalculatedState.java
ca4fe6e
ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/HBaseServiceCalculatedState.java
eac0dce
ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/HDFSServiceCalculatedState.java
7bbad2a
ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/HiveServiceCalculatedState.java
77e44a5
ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/OozieServiceCalculatedState.java
1803f70
ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/YARNServiceCalculatedState.java
2f1619f
ambari-server/src/main/java/org/apache/ambari/server/events/ServiceComponentInstalledEvent.java
0ba4ac2
ambari-server/src/main/java/org/apache/ambari/server/events/ServiceComponentUninstalledEvent.java
8acc401
ambari-server/src/main/java/org/apache/ambari/server/events/ServiceEvent.java
08f739e
ambari-server/src/main/java/org/apache/ambari/server/events/ServiceInstalledEvent.java
1f341d9
ambari-server/src/main/java/org/apache/ambari/server/events/ServiceRemovedEvent.java
de96342
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListener.java
2eb89a2
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ClusterServiceDAO.java
09419ec
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostComponentDesiredStateDAO.java
57e409c
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostComponentStateDAO.java
ad6867e
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ServiceComponentDesiredStateDAO.java
dfe7d7b
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ServiceGroupDAO.java
dc997b0
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterServiceEntity.java
2af9a47
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterServiceEntityPK.java
578edea
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostComponentDesiredStateEntity.java
36a7a25
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostComponentStateEntity.java
0d295a4
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceComponentDesiredStateEntity.java
e0f52c6
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceComponentVersionEntity.java
ffb3b82
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceDesiredStateEntity.java
fc26478
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceDesiredStateEntityPK.java
3fa5289
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceGroupEntity.java
cd9d2c8
ambari-server/src/main/java/org/apache/ambari/server/orm/models/HostComponentSummary.java
f5b12b5
ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java
ce4c961
ambari-server/src/main/java/org/apache/ambari/server/state/Service.java
65189ca
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponent.java
9fb2aba
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java
5ff9e37
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java
5f85e38
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceFactory.java
a4c953f
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java
0247774
ambari-server/src/main/java/org/apache/ambari/server/state/StackInfo.java
1494488
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
605cb7a
ambari-server/src/main/java/org/apache/ambari/server/state/host/HostImpl.java
3ceaa48
ambari-server/src/main/java/org/apache/ambari/server/state/repository/VersionDefinitionXml.java
45d8e8e
ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java
230b031
ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostSummary.java
e9359ef
ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java
662f9aa
ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql b1a13d3
ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 2beee0f
ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 190eb8b
ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 0f6b075
ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 668d1e7
ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql d7afe73
ambari-server/src/main/resources/key_properties.json 5d76062
ambari-server/src/main/resources/properties.json 11ca7f6
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalogHelper.java
58d4c3e
ambari-web/app/app.js 2c638e4
ambari-web/app/controllers/global/update_controller.js 8a3f984
ambari-web/app/controllers/main/admin/kerberos/step3_controller.js 15be4f9
ambari-web/app/controllers/main/service/add_controller.js c11bcf2
ambari-web/app/controllers/wizard/step8_controller.js cc06b5b
ambari-web/app/controllers/wizard/step9_controller.js 9f27f65
ambari-web/app/mappers/service_mapper.js 3523379
ambari-web/app/mappers/service_metrics_mapper.js 87b6149
ambari-web/app/mixins/common/configs/configs_saver.js dafee79
ambari-web/app/mixins/wizard/wizardProgressPageController.js 9d9d000
ambari-web/app/utils/ajax/ajax.js 4a1f9ef
Diff: https://reviews.apache.org/r/61917/diff/3/
Changes: https://reviews.apache.org/r/61917/diff/2-3/
Testing
-------
Manually tested by deplyoying cluster via UI.
Thanks,
Swapan Shridhar
