----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61993/#review184184 -----------------------------------------------------------
Ship it! The patch looks fine to me, but someone with Atlas expertise should probably review as well. Can you please add Vishal Suvagia to this review? Thanks. - Robert Nettleton On Aug. 30, 2017, 4:04 p.m., Miklos Gergely wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61993/ > ----------------------------------------------------------- > > (Updated Aug. 30, 2017, 4:04 p.m.) > > > Review request for Ambari, Oliver Szabo and Robert Nettleton. > > > Bugs: AMBARI-21855 > https://issues.apache.org/jira/browse/AMBARI-21855 > > > Repository: ambari > > > Description > ------- > > Atlas tries to create it's collection using the local ambari-infra Solr even > if it is specified to use an external one. > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata.py > 0305b82 > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py > 41be001 > > > Diff: https://reviews.apache.org/r/61993/diff/1/ > > > Testing > ------- > > Tested on two clusters, one running the external solr, the other installed > Atlas, the collections were created. > > > Thanks, > > Miklos Gergely > >
