-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62026/
-----------------------------------------------------------
Review request for Ambari and Dmytro Sen.
Bugs: AMBARI-21684
https://issues.apache.org/jira/browse/AMBARI-21684
Repository: ambari
Description
-------
"ambari-server upgrade" process still puts the new views jar to default
location even if views.dir is customized in ambari.properties
Tested with Ambari 2.2.1 to upgrade to Ambari 2.4.0.
Steps to reproduce:
1\. Stop Ambari Server.
2\. Move /var/lib/ambari-server/resources/views to a new custom directory.
3\. Add views.dir property in ambari.properties with above custom directory as
value.
4\. Restart Ambari server and it view works.
5\. Upgrade Ambari server.
6\. Views.dir still points to new custom directory but upgrade puts the new
jars again back to /var/lib/ambari-server/resources/views (default location).
7\. Views fails as jars are older than current Ambari version in the views.dir
location.
Every 2.0s: grep views.dir /etc/ambari-server/conf/ambari.properties
Tue Aug 8 17:22:29 2017
views.dir=/tmp/amogh/views
Every 2.0s: ls -l /tmp/amogh/views
Tue Aug 8 17:23:21 2017
total 326792
-rw-r--r-- 1 root root 571656 2017-08-08 00:42
ambari-admin-2.2.1.0.161.jar
-rw-r--r-- 1 root root 45378971 2017-08-08 00:42
capacity-scheduler-2.2.1.0.161.jar
-rw-r--r-- 1 root root 42834901 2017-08-08 00:42 files-2.2.1.0.161.jar
-rw-r--r-- 1 root root 98657707 2017-08-08 00:42 hive-2.2.1.0.161.jar
-rw-r--r-- 1 root root 46910268 2017-08-08 00:42 pig-2.2.1.0.161.jar
-rw-r--r-- 1 root root 52239902 2017-08-08 00:42 slider-2.2.1.0.161.jar
-rw-r--r-- 1 root root 48025481 2017-08-08 00:42 tez-view-2.2.1.0.161.jar
drwxr-xr-x 10 root root 4096 2017-08-08 00:46 work
-rw------- 1 root root 3309 2017-08-08 00:42
zeppelin-view-1.0-SNAPSHOT.jar
After Upgrage
Every 2.0s: ls -l /var/lib/ambari-server/resources/views
Tue Aug 8 17:23:44 2017
total 582628
-rwxrwxrwx 1 root root 917475 2016-08-30 19:29 ambari-admin-2.4.0.1.1.jar
-rwxrwxrwx 1 root root 45784224 2016-08-30 19:29
capacity-scheduler-2.4.0.1.1.jar
-rwxrwxrwx 1 root root 42287167 2016-08-30 19:29 files-2.4.0.1.1.jar
-rwxrwxrwx 1 root root 99518847 2016-08-30 19:29 hive-2.4.0.1.1.jar
-rwxrwxrwx 1 root root 126641271 2016-08-30 19:29 hive-jdbc-2.4.0.1.1.jar
-rwxrwxrwx 1 root root 35225272 2016-08-30 19:29
hueambarimigration-2.4.0.1.1.jar
-rwxrwxrwx 1 root root 47306795 2016-08-30 19:29 pig-2.4.0.1.1.jar
-rwxrwxrwx 1 root root 53071022 2016-08-30 19:29 slider-2.4.0.1.1.jar
-rwxrwxrwx 1 root root 1202086 2016-08-30 19:29 storm-view-2.4.0.1.1.jar
-rwxrwxrwx 1 root root 49835854 2016-08-30 19:29 tez-view-2.4.0.1.1.jar
-rwxrwxrwx 1 root root 49250942 2016-08-30 19:29 wfmanager-2.4.0.1.1.jar
-rwxrwxrwx 1 root root 45547958 2016-08-30 19:29
zeppelin-view-2.4.0.1.1.jar
Diffs
-----
ambari-server/src/main/python/ambari_server/serverConfiguration.py f6f3f43
ambari-server/src/main/python/ambari_server/serverUpgrade.py 07f5097
Diff: https://reviews.apache.org/r/62026/diff/1/
Testing
-------
mvn clean test
Thanks,
Andrew Onischuk
