> On Sept. 5, 2017, 12:44 p.m., Andrew Onischuk wrote: > > ambari-agent/src/main/python/ambari_agent/alerts/base_alert.py > > Line 149 (original), 149 (patched) > > <https://reviews.apache.org/r/62081/diff/1/?file=1814401#file1814401line149> > > > > Can we remove this line? > > Attila Doroszlai wrote: > Sure. Should I also remove cluster name from server-side alert code?
yes that's correct. Agent won't send that anymore. - Andrew ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62081/#review184532 ----------------------------------------------------------- On Sept. 5, 2017, 12:43 p.m., Attila Doroszlai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62081/ > ----------------------------------------------------------- > > (Updated Sept. 5, 2017, 12:43 p.m.) > > > Review request for Ambari, Andrew Onischuk, Myroslav Papirkovskyy, Sandor > Magyari, Sebastian Toader, and Sid Wagle. > > > Bugs: AMBARI-21878 > https://issues.apache.org/jira/browse/AMBARI-21878 > > > Repository: ambari > > > Description > ------- > > * Process alerts from agent at `/reports/alerts_status` > * Add `clusterId` to alert reports since cluster name is empty > > > Diffs > ----- > > ambari-agent/src/main/python/ambari_agent/alerts/base_alert.py > 76d83908883a1ad1c5ee44534592e86e6b75451a > > ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java > fce6be6a92104d775e5105c2056b05ff89abcfdf > > ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/AgentReportsController.java > 0152d89c80d5ef63850d3a9211ca7a6c7bcb72b5 > > ambari-server/src/main/java/org/apache/ambari/server/events/AlertReceivedEvent.java > b17071c7f384dba1cb508066fa5f808ada7487e4 > > ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertReceivedListener.java > 23a547fbdd7e1b1fb8b6c6e660daade1e51cb4e1 > ambari-server/src/main/java/org/apache/ambari/server/state/Alert.java > 1caa0e3221ac1452aa4822ad78e690f737dc878a > > > Diff: https://reviews.apache.org/r/62081/diff/1/ > > > Testing > ------- > > Manually tested on local cluster. > > > Thanks, > > Attila Doroszlai > >
