> On Sept. 5, 2017, 5:18 p.m., Sid Wagle wrote: > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java > > Lines 379 (patched) > > <https://reviews.apache.org/r/62072/diff/3/?file=1814453#file1814453line379> > > > > Why is this done during Ambari upgrade as well as stack upgrade? The > > presense of this property on existing stack should not cause ay issues > > after Amabri upgrade. > > Vitalyi Brodetskyi wrote: > Yes. it will not cause any issues. But as i understood, according to > first comment in jira "No issues, it’s just a warning. If Ambari sets this > config for Hive it should be fixed to not set it; this config does not > exist." they don't want hive to throw even WARN messages. And i'm not sure > about changes for BigInsight (stack upgrade), probably we don't need them, > what do you think?
The remove from upgrade pack seems sufficient to me. As long as default 4.2 and 4.2.5 installs of IOP does not contain this property we can safely skip the UpgradeCatalog changes. - Sid ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62072/#review184559 ----------------------------------------------------------- On Sept. 5, 2017, 3:06 p.m., Vitalyi Brodetskyi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62072/ > ----------------------------------------------------------- > > (Updated Sept. 5, 2017, 3:06 p.m.) > > > Review request for Ambari, Andrew Onischuk and Sid Wagle. > > > Bugs: AMBARI-21876 > https://issues.apache.org/jira/browse/AMBARI-21876 > > > Repository: ambari > > > Description > ------- > > Remove hive.custom-extensions.root from hive properties. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java > 5d50f29 > > ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/config-upgrade.xml > 4b53c7c > > ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/nonrolling-upgrade-to-hdp-2.6.xml > 48d1d92 > > ambari-server/src/main/resources/stacks/BigInsights/4.2/upgrades/config-upgrade.xml > 29fcac0 > > ambari-server/src/main/resources/stacks/BigInsights/4.2/upgrades/nonrolling-upgrade-to-hdp-2.6.xml > 1d4a6f4 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/custom_extensions.py > 63f6f70 > > ambari-server/src/main/resources/stacks/HDP/2.6/services/HIVE/configuration/hive-site.xml > c0800ed > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog260Test.java > d8e8171 > > > Diff: https://reviews.apache.org/r/62072/diff/3/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Vitalyi Brodetskyi > >
