-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62084/
-----------------------------------------------------------

(Updated Sept. 6, 2017, 8:41 a.m.)


Review request for Ambari, Attila Doroszlai, Attila Magyar, and Robert Levas.


Bugs: AMBARI-21882
    https://issues.apache.org/jira/browse/AMBARI-21882


Repository: ambari


Description
-------

Raise an exception in case an unsupported db type/jdbc driver is specified in 
HDP service configs.


Diffs
-----

  
ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py
 c80c577 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
 39c06f2 
  
ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/package/scripts/params_linux.py
 90d9067 
  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
 c31181d 
  
ambari-server/src/main/resources/common-services/RANGER/1.0.0.3.0/package/scripts/params.py
 24f459c 
  
ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py
 466646b 
  
ambari-server/src/main/resources/common-services/RANGER_KMS/1.0.0.3.0/package/scripts/params.py
 003eee1 
  
ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/params_linux.py
 c1138b3 
  
ambari-server/src/main/resources/common-services/SQOOP/1.4.4.3.0/package/scripts/params_linux.py
 c1138b3 
  ambari-server/src/main/resources/custom_actions/scripts/check_host.py a485415 
  ambari-server/src/test/python/common-services/HIVE/test_jdbc_driver_config.py 
PRE-CREATION 
  ambari-server/src/test/python/common-services/RANGER/test_db_flavor_config.py 
PRE-CREATION 
  
ambari-server/src/test/python/common-services/RANGER_KMS/test_db_flavor_config.py
 PRE-CREATION 
  
ambari-server/src/test/python/common-services/SQOOP/test_jdbc_driver_config.py 
PRE-CREATION 
  ambari-server/src/test/python/common-services/configs/hive_default.json 
PRE-CREATION 
  
ambari-server/src/test/python/common-services/configs/hive_unsupported_jdbc_type.json
 PRE-CREATION 
  
ambari-server/src/test/python/common-services/configs/ranger_admin_default.json 
PRE-CREATION 
  
ambari-server/src/test/python/common-services/configs/ranger_admin_unsupported_db_flavor.json
 PRE-CREATION 
  ambari-server/src/test/python/common-services/configs/ranger_kms_default.json 
PRE-CREATION 
  
ambari-server/src/test/python/common-services/configs/ranger_kms_unsupported_db_flavor.json
 PRE-CREATION 
  ambari-server/src/test/python/common-services/configs/sqoop_default.json 
PRE-CREATION 
  
ambari-server/src/test/python/common-services/configs/sqoop_unsupported_jdbc_driver.json
 PRE-CREATION 
  ambari-server/src/test/python/custom_actions/TestCheckHost.py 0d4e485 


Diff: https://reviews.apache.org/r/62084/diff/1/


Testing (updated)
-------

** mvn -pl ambari-server -DskipSurefireTests test **
```
----------------------------------------------------------------------
Ran 253 tests in 6.889s

OK
----------------------------------------------------------------------
Failed tests:
FAIL: test_start_secured (test_zeppelin_master.TestZeppelinMaster)
----------------------------------------------------------------------
Traceback (most recent call last):
  File 
"/Users/stoader/Projects/Hortonworks/apache/ambari/ambari-common/src/test/python/mock/mock.py",
 line 1199, in patched
    return func(*args, **keywargs)
  File 
"/Users/stoader/Projects/Hortonworks/apache/ambari/ambari-server/src/test/python/stacks/2.5/ZEPPELIN/test_zeppelin_master.py",
 line 324, in test_start_secured
    group = 'zeppelin',
  File 
"/Users/stoader/Projects/Hortonworks/apache/ambari/ambari-server/src/test/python/stacks/utils/RMFTestCase.py",
 line 328, in assertResourceCalled
    self.assertEquals(resource_type, resource.__class__.__name__)
AssertionError: 'File' != 'Execute'

----------------------------------------------------------------------
Total run:1194
Total errors:0
Total failures:1

```

The one failing test ```test_zeppelin_master.py``` is unrelated to this change.


Thanks,

Sebastian Toader

Reply via email to