> On Sept. 6, 2017, 12:43 a.m., Dmytro Grinenko wrote: > > ambari-server/src/main/java/org/apache/ambari/server/agent/CommandRepository.java > > Lines 113 (patched) > > <https://reviews.apache.org/r/62095/diff/1/?file=1815904#file1815904line113> > > > > what is the sense even to pass repositories if Ambari doesn't manage > > them ? CommandRepository should be enough > > > > optional: pass not-managed flag to tell that explicitly to the Agent as > > i dont really like the think to guessing on baseurl
i even could say, that we need to pass "not-managed" flag, as in yumrpm.py, zypper.py, apt.py we trying to scope some commands to repoID, which is not available for ambari in case of non-managed repositories. And the one supplied in repositoryFile, generated by Ambari is most likely wrong - Dmytro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62095/#review184611 ----------------------------------------------------------- On Sept. 5, 2017, 9:04 p.m., Nate Cole wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62095/ > ----------------------------------------------------------- > > (Updated Sept. 5, 2017, 9:04 p.m.) > > > Review request for Ambari, Dmytro Grinenko and Jonathan Hurley. > > > Bugs: AMBARI-21884 > https://issues.apache.org/jira/browse/AMBARI-21884 > > > Repository: ambari > > > Description > ------- > > Added fixes that broke RH Satellite option. > > @dgrinenko, this will likely conflict with your legacy patch. > > > Diffs > ----- > > > ambari-common/src/main/python/resource_management/libraries/functions/repository_util.py > 91009b0d2d > > ambari-server/src/main/java/org/apache/ambari/server/agent/CommandRepository.java > 3d961222b4 > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java > 26309fed99 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java > f96f257f9e > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java > fb4831edac > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/RepositoryVersionHelper.java > 227d42d419 > ambari-server/src/main/resources/version_definition.xsd 851e0d5c3c > > ambari-server/src/test/java/org/apache/ambari/server/actionmanager/ExecutionCommandWrapperTest.java > 94ad0d57fe > > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java > a60b696808 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java > 42b2a4caef > > > Diff: https://reviews.apache.org/r/62095/diff/1/ > > > Testing > ------- > > Manual. Automated: > > [WARNING] Tests run: 4843, Failures: 0, Errors: 0, Skipped: 35 > [INFO] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 24:13.075s > [INFO] Finished at: Tue Sep 05 17:26:36 EDT 2017 > [INFO] Final Memory: 68M/1908M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Nate Cole > >
