----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62119/#review184707 -----------------------------------------------------------
contrib/views/files/src/main/resources/ui/app/controllers/files.js Line 31 (original), 31 (patched) <https://reviews.apache.org/r/62119/#comment260902> What is the use of this counter variable? contrib/views/files/src/main/resources/ui/app/controllers/files.js Line 81 (original), 86 (patched) <https://reviews.apache.org/r/62119/#comment260904> This is not a good pattern to call API from Controller itself. this.store.query will return a promise and hence arrangedContents value can be a promise. Are you not getting any errors in console? Why is the filter cannot be a query parameter like 'path' and everytime the trottle typing fires why can't we reload the route with the the specified query params? I guess if you go by the reloading route way, the counter variable will also not be required and the hackery will be reduce. - DIPAYAN BHOWMICK On Sept. 6, 2017, 12:48 p.m., venkat sairam wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62119/ > ----------------------------------------------------------- > > (Updated Sept. 6, 2017, 12:48 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, > Padma Priya N, Pallav Kulshreshtha, and Prabhjyot Singh. > > > Bugs: AMBARI-21890 > https://issues.apache.org/jira/browse/AMBARI-21890 > > > Repository: ambari > > > Description > ------- > > A configurable limit have been imposed on the no of files being retrieved > from the server and the limit by default is set to 5000. > Search has been provided to find the file faster. > > > Diffs > ----- > > > contrib/views/commons/src/main/java/org/apache/ambari/view/commons/hdfs/FileOperationService.java > d6e484d > contrib/views/files/src/main/resources/ui/app/controllers/files.js 8b5bb7b > contrib/views/files/src/main/resources/ui/app/routes/files.js 140732f > contrib/views/files/src/main/resources/ui/app/templates/files.hbs 63e0dd8 > > contrib/views/files/src/test/java/org/apache/ambari/view/filebrowser/FilebrowserTest.java > f431f66 > > contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/DirListInfo.java > PRE-CREATION > > contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/DirStatus.java > PRE-CREATION > > contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/HdfsApi.java > 90fa483 > > contrib/views/utils/src/test/java/org/apache/ambari/view/utils/hdfs/HdfsApiTest.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/62119/diff/1/ > > > Testing > ------- > > Manual testing done. > > > Thanks, > > venkat sairam > >
