----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62128/#review184708 -----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeEntity.java Lines 89-96 (patched) <https://reviews.apache.org/r/62128/#comment260906> I'm not using this SQL anymore (although it did work). I feel like if we discover a problem with the other method, it would be good to have this to fall back on. I plan to add a coverage test for it. Seemed like a waste to get rid of it ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeEntity.java Lines 147-164 (patched) <https://reviews.apache.org/r/62128/#comment260905> I feel like this comment explains the workflow here pretty well. The "revertable" upgrades are essentially a stack. As you patch your cluster, we push the revertable upgrades onto a "stack". When you revert, we pop the most recent one off the stack, so the next upgrade without a downgrade becomes the most recent. - Jonathan Hurley On Sept. 6, 2017, 2:34 p.m., Jonathan Hurley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62128/ > ----------------------------------------------------------- > > (Updated Sept. 6, 2017, 2:34 p.m.) > > > Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, and Nate Cole. > > > Bugs: AMBARI-21894 > https://issues.apache.org/jira/browse/AMBARI-21894 > > > Repository: ambari > > > Description > ------- > > In the current PU UI, the revert button is shown for any PATCH type > repository. The backend should compute whether a version can be reverted. > > The backed should return a value, such as > {{ClusterStackVersions/supports_revert}} which clients, such as the web > client, can use. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java > f96f257f9e > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java > 722ec0f4d2 > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UpgradeDAO.java > 716f5b5221 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeEntity.java > 7f4824f6f1 > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/AbstractUpgradeServerAction.java > e012dacb17 > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java > 662dfef15c > > ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryType.java > 2e95c59b97 > > ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContext.java > 60f44bbe85 > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java > 5d50f29533 > ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 2e546dcee2 > ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql fefe1dc91e > ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 35866da9db > ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 1dce2ce7d4 > ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql > 5627cc18f6 > ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 07948364c5 > > > Diff: https://reviews.apache.org/r/62128/diff/2/ > > > Testing > ------- > > PENDING > > > Thanks, > > Jonathan Hurley > >
