----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62134/ -----------------------------------------------------------
Review request for Ambari, Jonathan Hurley, Robert Levas, and Sebastian Toader. Bugs: AMBARI-21898 https://issues.apache.org/jira/browse/AMBARI-21898 Repository: ambari Description ------- Building the hostComponentMap map for ProviderModule seems does unnecessary computation going through the ResourceProvider layer. On every configuration update, we call the reset on these maps which takes a long time to refresh. Instead, relying on org.apache.ambari.server.state.cluster.ClusterImpl#serviceComponentHosts will lead to faster computation without overhead like stale config calculations for every SCH. Diffs ----- ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java 5fc4c31 ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java ee18fdf ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 2f858b8 Diff: https://reviews.apache.org/r/62134/diff/1/ Testing ------- PropertyProvider tests are all green Pending unit tests and manual testing. Thanks, Sid Wagle