-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61886/
-----------------------------------------------------------
(Updated Sept. 7, 2017, 1:59 p.m.)
Review request for Ambari, Andrew Onischuk, Myroslav Papirkovskyy, Sandor
Magyari, Sebastian Toader, and Sid Wagle.
Changes
-------
* added @JsonProperty for all attributes (to explicitly specify names)
* added @JsonInclude to avoid `null` values
* simplified some equals()/hashCode() methods
Bugs: AMBARI-21803
https://issues.apache.org/jira/browse/AMBARI-21803
Repository: ambari
Description
-------
* Added endpoint
* Created data structure to match expected JSON format
* Extracted some common logic to parent classes
Diffs (updated)
-----
ambari-agent/src/main/python/ambari_agent/ClusterAlertDefinitionsCache.py
d3ab48e4da79cc7615bd5dedfec3754ffe5accc2
ambari-agent/src/main/python/ambari_agent/Constants.py
e36eda577d0195055ebe89e3eeac5c63aa4a460b
ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/AgentClusterDataHolder.java
0f0a4919ba7e1343c31c8397d5309542c2463287
ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/AgentConfigsHolder.java
0de686dfaad7a3c437fa5f9af5c1fa8abd4e61e8
ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/AgentCurrentDataController.java
7035f38cfbb7a75bd4cb5721a542ef832a805c99
ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/AgentDataHolder.java
635611bf6d325deb33cde671556647b9c264a716
ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/AgentHostDataHolder.java
792f10ef33363fd57579792f51901681ad83aa0b
ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/AlertDefinitionsHolder.java
PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/HostLevelParamsHolder.java
db093f85a7f304e895bad098a3ca5a62d7a3859d
ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/MetadataHolder.java
b7e680627f3fd42e87b7152f9ab9de29f63a44fa
ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/TopologyHolder.java
0da5d831d546da98e2284b048b914f972cacfc05
ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/dto/AlertCluster.java
PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/dto/MetadataCluster.java
3ee5ad6d00b4c4374cba48e80d1cb410500ee586
ambari-server/src/main/java/org/apache/ambari/server/events/AgentConfigsUpdateEvent.java
640be2d89bce55a9f58cbaf6b4e5296df9fc1a8c
ambari-server/src/main/java/org/apache/ambari/server/events/AlertDefinitionUpdateHolder.java
e820401d460bc672596a4ede60abcd39646be49e
ambari-server/src/main/java/org/apache/ambari/server/events/AlertDefinitionsUpdateEvent.java
cbe6e3703960ce0af9563f41b63d2a71427b4267
ambari-server/src/main/java/org/apache/ambari/server/events/HostLevelParamsUpdateEvent.java
66ab38ea39bea2c100a2245ad422a4c6a037d7ed
ambari-server/src/main/java/org/apache/ambari/server/events/MetadataUpdateEvent.java
239b5b8184a02a057c2dc9d4a53c671dc06d9806
ambari-server/src/main/java/org/apache/ambari/server/events/TopologyAgentUpdateEvent.java
1fa4e6c20d0b2d31e376b7b8e563326a7cc1e06a
ambari-server/src/main/java/org/apache/ambari/server/events/TopologyUpdateEvent.java
1b5b90b562babe4cea18a1bd93104d72922d31fa
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertDefinitionDAO.java
25bc8136510574cc54fa2f3365c755e6a9426547
ambari-server/src/main/java/org/apache/ambari/server/state/alert/AggregateSource.java
46ddd355b67e75da9cf98b365d830bd8cd7e20bd
ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertDefinition.java
e197cd0050c97fa655ceefa21a5763227c1890ec
ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertUri.java
c2ef5e7859464c22ce64a90a6c771eeff803ba38
ambari-server/src/main/java/org/apache/ambari/server/state/alert/AmsSource.java
21cf81c8cd0abd91940b73e60c40db4a68496637
ambari-server/src/main/java/org/apache/ambari/server/state/alert/MetricSource.java
25734cd496a3d3fa2f7f89716c1080ca2798c069
ambari-server/src/main/java/org/apache/ambari/server/state/alert/ParameterizedSource.java
92c49203a44bfd5d829f7f1835e97116029f1ee6
ambari-server/src/main/java/org/apache/ambari/server/state/alert/PercentSource.java
57bba06d723470e6f8c26a4961c7e37db05ebdfa
ambari-server/src/main/java/org/apache/ambari/server/state/alert/PortSource.java
e972c621d7361538105cb54734cb2c0b582daef8
ambari-server/src/main/java/org/apache/ambari/server/state/alert/Reporting.java
4aaefab33713c7641cab3775c615e87c1d96d82c
ambari-server/src/main/java/org/apache/ambari/server/state/alert/ScriptSource.java
d1b70701ae26c3117f7b9fb8ece2676c0f3d45cb
ambari-server/src/main/java/org/apache/ambari/server/state/alert/ServerSource.java
d5a69abcbb36bebd2776e61f5aa3ebcc3724df63
ambari-server/src/main/java/org/apache/ambari/server/state/alert/Source.java
76054a9c8cb3e0f79ce50c2b8be2699f0dd6741f
ambari-server/src/main/java/org/apache/ambari/server/state/alert/WebSource.java
a3c0ada908716e59db8516a8bdef75b7c2814806
Diff: https://reviews.apache.org/r/61886/diff/4/
Changes: https://reviews.apache.org/r/61886/diff/3-4/
Testing
-------
Manually tested server/agent restarts, alert definition changes.
Thanks,
Attila Doroszlai
