> On Sept. 7, 2017, 2:03 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java > > Lines 1239 (patched) > > <https://reviews.apache.org/r/62167/diff/1/?file=1817876#file1817876line1239> > > > > You can use RepositoryType.REVERTABLE here.
Will do. > On Sept. 7, 2017, 2:03 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java > > Lines 1242 (patched) > > <https://reviews.apache.org/r/62167/diff/1/?file=1817876#file1817876line1242> > > > > Can you just use RepositoryType.isRevertable() here? Really? Two issues on the same code block? - Nate ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62167/#review184849 ----------------------------------------------------------- On Sept. 7, 2017, 1:52 p.m., Nate Cole wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62167/ > ----------------------------------------------------------- > > (Updated Sept. 7, 2017, 1:52 p.m.) > > > Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley. > > > Bugs: AMBARI-21906 > https://issues.apache.org/jira/browse/AMBARI-21906 > > > Repository: ambari > > > Description > ------- > > Skip orchestration of configuration types. Add the ability to xsd just in > case we ever need to do such configs without hardcoding the behavior. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java > 3d72a6ec7e > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigureTask.java > b7be2ec1fd > ambari-server/src/main/resources/upgrade-pack.xsd aa7ddd8c80 > > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java > 856f2faa67 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java > 9c961daeba > > ambari-server/src/test/java/org/apache/ambari/server/state/stack/UpgradePackTest.java > 616139c5bf > > ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test_force_config_change.xml > PRE-CREATION > ambari-server/src/test/resources/version_definition_test_patch_config.xml > PRE-CREATION > > > Diff: https://reviews.apache.org/r/62167/diff/1/ > > > Testing > ------- > > Manual. Automated pending. > > > Thanks, > > Nate Cole > >
