----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62169/#review184870 -----------------------------------------------------------
Ship it! LGTM. - Swapan Shridhar On Sept. 7, 2017, 7:49 p.m., Sid Wagle wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62169/ > ----------------------------------------------------------- > > (Updated Sept. 7, 2017, 7:49 p.m.) > > > Review request for Ambari, Aravindan Vijayan, Jonathan Hurley, and Swapan > Shridhar. > > > Bugs: AMBARI-21908 > https://issues.apache.org/jira/browse/AMBARI-21908 > > > Repository: ambari > > > Description > ------- > > Cannot create config group, server returns 500 error. > > Form data: > {code} > {noformat} > [{"ConfigGroup":{"group_name":"11","tag":"HDFS","description":"","desired_configs":[],"hosts":[]},"serviceName":"HDFS"}] > {noformat} > {code} > > Exception: > {noformat} > { > "status" : 400, > "message" : "The properties [ConfigGroup/serviceName] specified in the > request or predicate are not supported for the resource type ConfigGroup." > } > {noformat} > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/ConfigGroupRequest.java > efa1a7e > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ConfigGroupResourceProvider.java > 0ea54cb > > ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java > da517f3 > ambari-server/src/main/resources/properties.json 80a86b8 > > > Diff: https://reviews.apache.org/r/62169/diff/1/ > > > Testing > ------- > > Manually verified. > Affected unit tests are green. > > > Thanks, > > Sid Wagle > >
