----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62245/ -----------------------------------------------------------
(Updated Sept. 13, 2017, 5:15 p.m.) Review request for Ambari, Jonathan Hurley and Nate Cole. Changes ------- Addressed Jonathans comment. Also, changed checks to warn instead of failure (according to Should only WARN column in table from jira) Summary (updated) ----------------- Preview. Auto fix enhancement to remove more than 1 selected configs Bugs: AMBARI-21935 https://issues.apache.org/jira/browse/AMBARI-21935 Repository: ambari Description ------- Sometimes Ambari is coming up with issues like more than 1 selected configs. Error: {noformat} ERROR - You have config(s), in cluster BMOHDPQA01, that is(are) selected more than once in clusterconfigmapping table: falcon-startup.properties,zoo.cfg,zeppelin-config,zookeeper-log4j,tagsync-application-properties,storm-worker-log4j,hive-log4j2,admin-properties,oozie-env,ssl-server,hadoop-policy,infra-solr-log4j,oozie-log4j,core-site,mahout-log4j,kafka-broker,pig-log4j,livy-env,zeppelin-env,hive-log4j,slider-client,tez-env,storm-env,ranger-storm-plugin-properties,oozie-site,falcon-env,beeline-log4j2,ranger-storm-policymgr-ssl,falcon-runtime.properties,ranger-storm-security,hbase-policy,ams-env,capacity-scheduler,webhcat-log4j,atlas-log4j,livy-log4j-properties,spark-metrics-properties,hbase-env,ranger-atlas-security,flume-env,sqoop-atlas-application.properties,admin-log4j,hiveserver2-interactive-site,ranger-tagsync-site,application-properties,ranger-kafka-policymgr-ssl,ranger-admin-site,ranger-env,ranger-storm-audit,ranger-hbase-policymgr-ssl,hdfs-log4j {noformat} It is very difficult to fix these kind of issues with queries. including auto fix for this will be very helpful. Diffs (updated) ----- ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java 575485bd54 ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ClusterDAO.java a23b914f34 ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterConfigEntity.java 9bf03b343f ambari-server/src/test/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelperTest.java 6c6c00f947 Diff: https://reviews.apache.org/r/62245/diff/2/ Changes: https://reviews.apache.org/r/62245/diff/1-2/ Testing (updated) ------- still updating tests Thanks, Dmitro Lisnichenko