> On Sept. 13, 2017, 7:56 p.m., Sid Wagle wrote: > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py > > Lines 873 (patched) > > <https://reviews.apache.org/r/62292/diff/1/?file=1821171#file1821171line873> > > > > Is this left behind artifact?
Yes, just a missed print line. I will remove it before the commit. - Aravindan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62292/#review185333 ----------------------------------------------------------- On Sept. 13, 2017, 7:49 p.m., Aravindan Vijayan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62292/ > ----------------------------------------------------------- > > (Updated Sept. 13, 2017, 7:49 p.m.) > > > Review request for Ambari, Dmytro Sen, Jayush Luniya, and Sid Wagle. > > > Bugs: AMBARI-21952 > https://issues.apache.org/jira/browse/AMBARI-21952 > > > Repository: ambari > > > Description > ------- > > Refined stack advisor recommendations for AMS heap sizing. > Added validation for 'distributed' mode when number of sinks > 1000. > Added validation for HBase heapsizes > 32G > Removed unneeded validations for gouging unused memory on metrics collector > host. > > > Diffs > ----- > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py > 7992c95 > ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py > 35af503 > ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py > 9c6bef1 > > > Diff: https://reviews.apache.org/r/62292/diff/1/ > > > Testing > ------- > > Manually tested. > Python unit tests passed. > > > File Attachments > ---------------- > > Heap estimates for various size clusters > > https://reviews.apache.org/media/uploaded/files/2017/09/13/ce769beb-f026-4d9e-9530-3218327584be__Screen_Shot_2017-09-13_at_12.13.24_PM.png > > > Thanks, > > Aravindan Vijayan > >
