-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62351/#review185489
-----------------------------------------------------------




ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java
Lines 621-658 (patched)
<https://reviews.apache.org/r/62351/#comment261779>

    This will cause Ranger configurations to change during upgrade, which will 
require a restart. We typically don't do this during Ambari upgrades since it 
would lead to extra downtime. These settings can be configured manually after 
upgrading Ambari, no?
    
    Also - we shouldn't be referring to stacks by name and version. This kind 
of tight coupling is what we're trying to get away from. You should, instead, 
query the current cluster stack to see if it supports those properties.


- Jonathan Hurley


On Sept. 15, 2017, 8:41 a.m., Mugdha Varadkar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62351/
> -----------------------------------------------------------
> 
> (Updated Sept. 15, 2017, 8:41 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jonathan 
> Hurley, Jayush Luniya, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-21910
>     https://issues.apache.org/jira/browse/AMBARI-21910
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> As part of RANGER-1735, we are supporting nested groups in ranger usersync. 
> For this, introduced one new property 
> "ranger.usersync.ldap.grouphierarchylevels". The value should be an integer 
> with default value as 0. This property should be under Ranger --> Configs --> 
> Ranger User Info --> Group Configs tab.
> This property can be enabled with a flag labelled as "Sync Nested Groups". 
> 1. Default value for this flag is "No"
> 2. This flag is always shown under Group Configs (even when "Enable group 
> Sync" is set to "No")
> 3. If this flag is set to "No", then the value for 
> ranger.usersync.ldap.grouphierarchylevels is hidden and is set to "0". 
> 4. If this flag is set to "Yes", then 
> ranger.usersync.ldap.grouphierarchylevels is shown and allowed to set any 
> integer greater than 0.
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java
>  a56bda2 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.7.0/configuration/ranger-env.xml
>  627216e 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.7.0/configuration/ranger-ugsync-site.xml
>  a994856 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.7.0/themes/theme_version_5.json
>  8068a38 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog260Test.java
>  e363c8d 
> 
> 
> Diff: https://reviews.apache.org/r/62351/diff/1/
> 
> 
> Testing
> -------
> 
> Test Fresh Installs.
> Ambari upgrade with stack 2.6.
> Unit Test passed for UpgradeCatalog260Test.
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Reply via email to