> On Sept. 18, 2017, 10:56 a.m., Jonathan Hurley wrote: > > ambari-server/pom.xml > > Lines 1598-1600 (original), 1598-1600 (patched) > > <https://reviews.apache.org/r/62290/diff/3/?file=1827992#file1827992line1598> > > > > Seems like a few things depend on jackson-annotations. Did you check to > > see if there are any backward-compatibility issues with bumping the version?
I compiled, successfully ran the unit tests, and successfully installed a cluster. From what I can tell, in the Ambari server, the jackson libs are used in the code that executes the service advisor. Since there were no problems with the installation of a new cluster, I assume all should be good. > On Sept. 18, 2017, 10:56 a.m., Jonathan Hurley wrote: > > ambari-server/src/test/java/org/apache/ambari/server/stack/KerberosDescriptorTest.java > > Lines 95 (patched) > > <https://reviews.apache.org/r/62290/diff/3/?file=1828002#file1828002line138> > > > > Should we use Logging here instead of System? I will fix this - Robert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62290/#review185554 ----------------------------------------------------------- On Sept. 15, 2017, 10:34 a.m., Robert Levas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62290/ > ----------------------------------------------------------- > > (Updated Sept. 15, 2017, 10:34 a.m.) > > > Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene > Chekanskiy, Jonathan Hurley, Laszlo Puskas, Mugdha Varadkar, and Sebastian > Toader. > > > Bugs: AMBARI-21938 > https://issues.apache.org/jira/browse/AMBARI-21938 > > > Repository: ambari > > > Description > ------- > > Validate kerberos.json files to ensure they meet the expected schema. > > > Diffs > ----- > > ambari-server/pom.xml 29a820a329 > > ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/AbstractKerberosDescriptor.java > 0d1da9c743 > > ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/AbstractKerberosDescriptorContainer.java > 5658133c9b > > ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosComponentDescriptor.java > 768a17e3b3 > > ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosDescriptor.java > 0eb3733584 > > ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosIdentityDescriptor.java > 911723b80b > > ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosKeytabDescriptor.java > a17caadda0 > > ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosPrincipalDescriptor.java > 74254e3fe3 > > ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosServiceDescriptor.java > 5da33997ab > ambari-server/src/main/resources/stacks/HDP/2.6/kerberos_preconfigure.json > c9d8c91372 > > ambari-server/src/test/java/org/apache/ambari/server/stack/KerberosDescriptorTest.java > 0f1dd55044 > > ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosComponentDescriptorTest.java > 09699c6fd6 > > ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosConfigurationDescriptorTest.java > e891fdea4e > > ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosDescriptorTest.java > 7fb56248e5 > > ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosDescriptorUpdateHelperTest.java > 44812de55d > > ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosIdentityDescriptorTest.java > d11962b9a3 > > ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosKeytabDescriptorTest.java > 8cdb39e02e > > ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosPrincipalDescriptorTest.java > b84223f421 > > ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosServiceDescriptorTest.java > e4d3c90767 > ambari-server/src/test/resources/kerberos_descriptor_schema.json > PRE-CREATION > > > Diff: https://reviews.apache.org/r/62290/diff/3/ > > > Testing > ------- > > Ensured the following unit tests passed: > > - org.apache.ambari.server.stack.KerberosDescriptorTest > - org.apache.ambari.server.state.kerberos.KerberosComponentDescriptorTest > - org.apache.ambari.server.state.kerberos.KerberosConfigurationDescriptorTest > - org.apache.ambari.server.state.kerberos.KerberosDescriptorTest > - org.apache.ambari.server.state.kerberos.KerberosIdentityDescriptorTest > - org.apache.ambari.server.state.kerberos.KerberosKeytabDescriptorTest > - org.apache.ambari.server.state.kerberos.KerberosPrincipalDescriptorTest > - org.apache.ambari.server.state.kerberos.KerberosServiceDescriptorTest > > > Thanks, > > Robert Levas > >
