> On Sept. 18, 2017, 6:34 p.m., Dmitro Lisnichenko wrote: > > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service.py > > Lines 88 (patched) > > <https://reviews.apache.org/r/62388/diff/1/?file=1828625#file1828625line88> > > > > Sounds like a very dirty hack. Does that reproduce in latest Ambari > > versions? Maybe it would be better to check status() before attempt to run > > start() ? > > Andrew Onischuk wrote: > +1. Checking output might break with a simple change to ats, also if they > decide to make multilingual output like some linux utils already done. Having > different locale it will break too.
I saw the same issues after QE reset their cluster but for some reason they didn't stop ATS. And pid was deleted. So ATS what just running without pid file. If that's the case we have it's QE issue. In other case as mentioned by Dmitro, we can check status before start. - Andrew ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62388/#review185594 ----------------------------------------------------------- On Sept. 18, 2017, 6 p.m., Eugene Chekanskiy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62388/ > ----------------------------------------------------------- > > (Updated Sept. 18, 2017, 6 p.m.) > > > Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, and Robert > Levas. > > > Bugs: AMBARI-21984 > https://issues.apache.org/jira/browse/AMBARI-21984 > > > Repository: ambari > > > Description > ------- > > Sometimes scripts starting yarn services but they are already running. It is > rarely reproduced and hard to debug. > This patch checks output of start command and ignore start failure in case > script reporting "service is running" and validates pid pile after that. > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service.py > 7c59b60 > > ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/package/scripts/service.py > 1c612ef > ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py > 6a99dfa > ambari-server/src/test/python/stacks/2.0.6/YARN/test_nodemanager.py 642043d > ambari-server/src/test/python/stacks/2.0.6/YARN/test_resourcemanager.py > 8a703df > ambari-server/src/test/python/stacks/2.1/YARN/test_apptimelineserver.py > b352920 > > > Diff: https://reviews.apache.org/r/62388/diff/1/ > > > Testing > ------- > > mvn clean test, cluster deploy > > > Thanks, > > Eugene Chekanskiy > >
