----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62324/#review185716 -----------------------------------------------------------
Ship it! Looks good. Tested by installing in Ambari along with Storm. - Sriharsha Chintalapani On Sept. 14, 2017, 7:11 a.m., Sanket Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62324/ > ----------------------------------------------------------- > > (Updated Sept. 14, 2017, 7:11 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Sumit Mohanty, and Sriharsha > Chintalapani. > > > Bugs: AMBARI-21955 > https://issues.apache.org/jira/browse/AMBARI-21955 > > > Repository: ambari > > > Description > ------- > > The Apache Software Foundation Legal Affairs Committee has announced that the > so-called 'Facebook BSD+Patents License' is no longer allowed to be used as a > direct dependency in Apache projects. > > Since Storm View is using React.js which is under the same Facebook's > license, needs to get rid of and use Vue.js instead. > > > Diffs > ----- > > .gitignore a40e61a > contrib/views/storm/pom.xml cd92658 > contrib/views/storm/src/main/resources/images/icon-bolt.png > contrib/views/storm/src/main/resources/images/icon-spout.png > contrib/views/storm/src/main/resources/images/loader.gif > contrib/views/storm/src/main/resources/index.html df94a76 > > contrib/views/storm/src/main/resources/libs/Backbone-Paginator/js/backbone-paginator.min.js > d8ccc65 > contrib/views/storm/src/main/resources/libs/Backbone/js/Backbone.js f246b10 > > contrib/views/storm/src/main/resources/libs/Bootstrap/css/bootstrap-editable.css > 50543a7 > > contrib/views/storm/src/main/resources/libs/Bootstrap/css/bootstrap-slider.min.css > d30595c > > contrib/views/storm/src/main/resources/libs/Bootstrap/css/bootstrap-switch.min.css > c63cfe2 > contrib/views/storm/src/main/resources/libs/Bootstrap/css/bootstrap.css > 5a77806 > > contrib/views/storm/src/main/resources/libs/Bootstrap/fonts/glyphicons-halflings-regular.eot > b93a4953fff68df523aa7656497ee339d6026d64 > > contrib/views/storm/src/main/resources/libs/Bootstrap/fonts/glyphicons-halflings-regular.svg > 94fb549 > > contrib/views/storm/src/main/resources/libs/Bootstrap/fonts/glyphicons-halflings-regular.ttf > 1413fc609ab6f21774de0cb7e01360095584f65b > > contrib/views/storm/src/main/resources/libs/Bootstrap/fonts/glyphicons-halflings-regular.woff > 9e612858f802245ddcbf59788a0db942224bab35 > > contrib/views/storm/src/main/resources/libs/Bootstrap/fonts/glyphicons-halflings-regular.woff2 > 64539b54c3751a6d9adb44c8e3a45ba5a73b77f0 > contrib/views/storm/src/main/resources/libs/Bootstrap/images/clear.png > 580b52a5be8a644f826def0c7ed6a13f90c0915c > contrib/views/storm/src/main/resources/libs/Bootstrap/images/loading.gif > 5b33f7e54f4e55b6b8774d86d96895db9af044b4 > > contrib/views/storm/src/main/resources/libs/Bootstrap/js/bootstrap-editable.min.js > b786a84 > > contrib/views/storm/src/main/resources/libs/Bootstrap/js/bootstrap-notify.min.js > 01e7f30 > > contrib/views/storm/src/main/resources/libs/Bootstrap/js/bootstrap-slider.min.js > e61cd83 > > contrib/views/storm/src/main/resources/libs/Bootstrap/js/bootstrap-switch.min.js > 9849658 > contrib/views/storm/src/main/resources/libs/Bootstrap/js/bootstrap.min.js > e79c065 > > contrib/views/storm/src/main/resources/libs/Font-Awesome/css/font-awesome.min.css > d0603cb > > contrib/views/storm/src/main/resources/libs/Font-Awesome/fonts/FontAwesome.otf > 3ed7f8b48ad9bfab52eb03822fefcd6b77d2e680 > > contrib/views/storm/src/main/resources/libs/Font-Awesome/fonts/fontawesome-webfont.eot > 9b6afaedc0fd7aaf927a07f82da9c11022251b8b > > contrib/views/storm/src/main/resources/libs/Font-Awesome/fonts/fontawesome-webfont.svg > d05688e > > contrib/views/storm/src/main/resources/libs/Font-Awesome/fonts/fontawesome-webfont.ttf > 26dea7951a73079223b50653c455c5adf46a4648 > > contrib/views/storm/src/main/resources/libs/Font-Awesome/fonts/fontawesome-webfont.woff > dc35ce3c2cf688c89b0bd0d4a82bc4be82b14c40 > > contrib/views/storm/src/main/resources/libs/Font-Awesome/fonts/fontawesome-webfont.woff2 > 500e5172534171f678e01f7569d66f9257036a09 > contrib/views/storm/src/main/resources/libs/Underscore/js/Underscore.js > dfd89b2 > contrib/views/storm/src/main/resources/libs/bootbox/js/bootbox.min.js > 0dc0cbd > contrib/views/storm/src/main/resources/libs/d3/js/d3-tip.min.js 4767cc0 > contrib/views/storm/src/main/resources/libs/d3/js/d3.min.js 2856dd2 > contrib/views/storm/src/main/resources/libs/dagre-d3/dagre-d3.min.js > b4821d8 > contrib/views/storm/src/main/resources/libs/jQuery/js/jquery-2.2.3.min.js > b8c4187 > contrib/views/storm/src/main/resources/libs/jsx/JSXTransformer.js efc63ff > contrib/views/storm/src/main/resources/libs/jsx/jsx.js 0a72088 > contrib/views/storm/src/main/resources/libs/react/js/react-dom.js e9faebd > contrib/views/storm/src/main/resources/libs/react/js/react-with-addons.js > 5b451eb > contrib/views/storm/src/main/resources/libs/require-js/js/require.min.js > a6d55d5 > contrib/views/storm/src/main/resources/libs/require-text/js/text.js 49e242c > > contrib/views/storm/src/main/resources/scripts/collections/BaseCollection.js > ab1b64a > > contrib/views/storm/src/main/resources/scripts/collections/VNimbusConfigList.js > a372299 > contrib/views/storm/src/main/resources/scripts/collections/VNimbusList.js > a6f2108 > > contrib/views/storm/src/main/resources/scripts/collections/VSupervisorList.js > 5bc066c > > contrib/views/storm/src/main/resources/scripts/collections/VTopologyConfigList.js > 250517f > contrib/views/storm/src/main/resources/scripts/collections/VTopologyList.js > 82297d5 > contrib/views/storm/src/main/resources/scripts/components/BarChart.jsx > ef05422 > contrib/views/storm/src/main/resources/scripts/components/Breadcrumbs.jsx > deff030 > contrib/views/storm/src/main/resources/scripts/components/Modal.jsx 3ac9d8c > contrib/views/storm/src/main/resources/scripts/components/RadialChart.jsx > 10432a8 > contrib/views/storm/src/main/resources/scripts/components/SearchLogs.jsx > 1581a16 > contrib/views/storm/src/main/resources/scripts/components/Table.jsx d5d06ef > contrib/views/storm/src/main/resources/scripts/components/TopologyGraph.jsx > 8679661 > > contrib/views/storm/src/main/resources/scripts/containers/ClusterSummary.jsx > ad0d9d7 > > contrib/views/storm/src/main/resources/scripts/containers/NimbusConfigSummary.jsx > 19846c8 > contrib/views/storm/src/main/resources/scripts/containers/NimbusSummary.jsx > be2f18d > > contrib/views/storm/src/main/resources/scripts/containers/SupervisorSummary.jsx > 15fe53a > > contrib/views/storm/src/main/resources/scripts/containers/TopologyConfiguration.jsx > 21dc4ff > > contrib/views/storm/src/main/resources/scripts/containers/TopologyDetailGraph.jsx > e19cb30 > > contrib/views/storm/src/main/resources/scripts/containers/TopologyListing.jsx > 4c624cb > contrib/views/storm/src/main/resources/scripts/main.js 7bd2201 > contrib/views/storm/src/main/resources/scripts/models/BaseModel.js 225788e > contrib/views/storm/src/main/resources/scripts/models/VCluster.js 46bcf9d > contrib/views/storm/src/main/resources/scripts/models/VNimbus.js 02bbc1f > contrib/views/storm/src/main/resources/scripts/models/VNimbusConfig.js > ce8997b > contrib/views/storm/src/main/resources/scripts/models/VSupervisor.js > fa8ebbb > contrib/views/storm/src/main/resources/scripts/models/VTopology.js c746935 > contrib/views/storm/src/main/resources/scripts/models/VTopologyConfig.js > c4dd46c > > contrib/views/storm/src/main/resources/scripts/modules/Table/PageableTable.jsx > 7d39e25 > contrib/views/storm/src/main/resources/scripts/modules/Table/Pagination.jsx > 985a760 > contrib/views/storm/src/main/resources/scripts/router/Router.js be6943e > contrib/views/storm/src/main/resources/scripts/utils/Globals.js c28d45f > contrib/views/storm/src/main/resources/scripts/utils/Overrides.js 1170e04 > contrib/views/storm/src/main/resources/scripts/utils/Utils.js d9a9dd6 > > contrib/views/storm/src/main/resources/scripts/views/ComponentDetailView.jsx > 5847ef9 > contrib/views/storm/src/main/resources/scripts/views/Dashboard.jsx 3f4f682 > contrib/views/storm/src/main/resources/scripts/views/Footer.jsx 98e63e9 > contrib/views/storm/src/main/resources/scripts/views/NimbusSummaryView.jsx > 6221d3f > contrib/views/storm/src/main/resources/scripts/views/ProfilingView.jsx > f5ffefe > contrib/views/storm/src/main/resources/scripts/views/RebalanceView.jsx > 33f5963 > > contrib/views/storm/src/main/resources/scripts/views/SupervisorSummaryView.jsx > 5827147 > contrib/views/storm/src/main/resources/scripts/views/TopologyDetailView.jsx > 136d95f > > contrib/views/storm/src/main/resources/scripts/views/TopologyListingView.jsx > 25441fa > contrib/views/storm/src/main/resources/styles/style.css f6b1685 > contrib/views/storm/src/main/resources/ui/.babelrc PRE-CREATION > contrib/views/storm/src/main/resources/ui/.editorconfig PRE-CREATION > contrib/views/storm/src/main/resources/ui/.eslintignore PRE-CREATION > contrib/views/storm/src/main/resources/ui/.eslintrc.js PRE-CREATION > contrib/views/storm/src/main/resources/ui/.gitignore PRE-CREATION > contrib/views/storm/src/main/resources/ui/.postcssrc.js PRE-CREATION > contrib/views/storm/src/main/resources/ui/build/build.js PRE-CREATION > contrib/views/storm/src/main/resources/ui/build/check-versions.js > PRE-CREATION > contrib/views/storm/src/main/resources/ui/build/dev-server.js PRE-CREATION > contrib/views/storm/src/main/resources/ui/build/utils.js PRE-CREATION > contrib/views/storm/src/main/resources/ui/build/webpack.base.conf.js > PRE-CREATION > contrib/views/storm/src/main/resources/ui/build/webpack.dev.conf.js > PRE-CREATION > contrib/views/storm/src/main/resources/ui/build/webpack.prod.conf.js > PRE-CREATION > contrib/views/storm/src/main/resources/ui/config/index.js PRE-CREATION > contrib/views/storm/src/main/resources/ui/index.html PRE-CREATION > contrib/views/storm/src/main/resources/ui/package.json PRE-CREATION > contrib/views/storm/src/main/resources/ui/src/App.vue PRE-CREATION > > contrib/views/storm/src/main/resources/ui/src/assets/css/font-awesome.min.css > PRE-CREATION > > contrib/views/storm/src/main/resources/ui/src/assets/fonts/fontawesome-webfont.eot > PRE-CREATION > > contrib/views/storm/src/main/resources/ui/src/assets/fonts/fontawesome-webfont.woff > PRE-CREATION > > contrib/views/storm/src/main/resources/ui/src/assets/fonts/fontawesome-webfont.woff2 > PRE-CREATION > contrib/views/storm/src/main/resources/ui/src/assets/img/start-loader.gif > PRE-CREATION > contrib/views/storm/src/main/resources/ui/src/components/BarChart.vue > PRE-CREATION > contrib/views/storm/src/main/resources/ui/src/components/Breadcrumbs.vue > PRE-CREATION > contrib/views/storm/src/main/resources/ui/src/components/CommonExpanded.vue > PRE-CREATION > > contrib/views/storm/src/main/resources/ui/src/components/CommonSwitchComponent.vue > PRE-CREATION > contrib/views/storm/src/main/resources/ui/src/components/CommonTable.vue > PRE-CREATION > > contrib/views/storm/src/main/resources/ui/src/components/CommonWindowPanel.vue > PRE-CREATION > contrib/views/storm/src/main/resources/ui/src/components/Editable.vue > PRE-CREATION > contrib/views/storm/src/main/resources/ui/src/components/FSModal.vue > PRE-CREATION > contrib/views/storm/src/main/resources/ui/src/components/Footer.vue > PRE-CREATION > > contrib/views/storm/src/main/resources/ui/src/components/LogLevelComponent.vue > PRE-CREATION > contrib/views/storm/src/main/resources/ui/src/components/ProfilingView.vue > PRE-CREATION > contrib/views/storm/src/main/resources/ui/src/components/RadialChart.vue > PRE-CREATION > > contrib/views/storm/src/main/resources/ui/src/components/RebalanceTopology.vue > PRE-CREATION > contrib/views/storm/src/main/resources/ui/src/components/SearchLogs.vue > PRE-CREATION > > contrib/views/storm/src/main/resources/ui/src/components/ToggleComponent.vue > PRE-CREATION > contrib/views/storm/src/main/resources/ui/src/components/TopologyGraph.vue > PRE-CREATION > contrib/views/storm/src/main/resources/ui/src/components/VueSelect.vue > PRE-CREATION > contrib/views/storm/src/main/resources/ui/src/containers/ClusterSummary.vue > PRE-CREATION > > contrib/views/storm/src/main/resources/ui/src/containers/ComponentDetailView.vue > PRE-CREATION > contrib/views/storm/src/main/resources/ui/src/containers/Dashboard.vue > PRE-CREATION > > contrib/views/storm/src/main/resources/ui/src/containers/NimbusConfigSummary.vue > PRE-CREATION > contrib/views/storm/src/main/resources/ui/src/containers/NimbusSummary.vue > PRE-CREATION > > contrib/views/storm/src/main/resources/ui/src/containers/SupervisorSummary.vue > PRE-CREATION > > contrib/views/storm/src/main/resources/ui/src/containers/TopologyDetailView.vue > PRE-CREATION > > contrib/views/storm/src/main/resources/ui/src/containers/TopologyListing.vue > PRE-CREATION > contrib/views/storm/src/main/resources/ui/src/rest/TopologyREST.js > PRE-CREATION > contrib/views/storm/src/main/resources/ui/src/router/routes.js PRE-CREATION > contrib/views/storm/src/main/resources/ui/src/utils/EventBus.js > PRE-CREATION > contrib/views/storm/src/main/resources/ui/src/utils/FSToaster.vue > PRE-CREATION > contrib/views/storm/src/main/resources/ui/src/utils/FilterUtils.js > PRE-CREATION > contrib/views/storm/src/main/resources/ui/static/.gitkeep PRE-CREATION > pom.xml 37bb137 > > > Diff: https://reviews.apache.org/r/62324/diff/1/ > > > Testing > ------- > > Manually ran the mvn clean install and created storm view jar. > Successfully deployed the jar and verified working of storm view. > > > Thanks, > > Sanket Shah > >